cardano-testnet-test: small improvements #5962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smelc
changed the title
smelc
changed the title
smelc
force-pushed
the
smelc/cardano-testnet-remove-unused-option
branch
from
1753af9
to
0d6082e
Compare
Base automatically changed from
smelc/honor-cardano-testnet-max-supply-value
to
master
August 29, 2024 18:25
carbolymer
approved these changes
Aug 30, 2024
smelc
force-pushed
the
smelc/cardano-testnet-remove-unused-option
branch
3 times, most recently
from
80fb3ee
to
81c84f7
Compare
smelc
changed the title
smelc
force-pushed
the
smelc/cardano-testnet-remove-unused-option
branch
from
81c84f7
to
a245cd5
Compare
|
Are we using P2P stack in tests? Note that the non-p2p stack will be removed at some point. |
|
@coot> I believe we don't use P2p in → cat /tmp/nix-shell.3H7AVw/cli-queries-test-23d51bd100cd79ee/configuration.yaml | grep P2P
"EnableP2P": false, |
|
Let me amend the PR then, to keep the flag then and honor it instead of doing nothing with it 🙂 |
|
Honoring P2P will affect other work I have stacked on this one, so I'll just keep the "small improvements" bits of this PR and merge. P2P honoring will come later. |
smelc
force-pushed
the
smelc/cardano-testnet-remove-unused-option
branch
from
a245cd5
to
47cc7cc
Compare
smelc
changed the title
|
Note that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes initialization of fields in
cardano-testnet-testthat were useless because they were initializing said fields with the same value as the default values. It also does QoL improvements.Checklist