Names of metrics in the new tracing system #5905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jutaro
force-pushed
the
jutaro/metrics_renaming
branch
from
602952f
to
eb7538a
Compare
jutaro
force-pushed
the
jutaro/metrics_renaming
branch
2 times, most recently
from
de52986
to
575813b
Compare
cardano-node/src/Cardano/Node/Tracing/Tracers/ForgingThreadStats.hs
Outdated
Show resolved
Hide resolved
jutaro
force-pushed
the
jutaro/metrics_renaming
branch
2 times, most recently
from
aff5c6f
to
bc7c8f3
Compare
jutaro
force-pushed
the
jutaro/metrics_renaming
branch
from
bc7c8f3
to
7bf005f
Compare
jutaro
force-pushed
the
jutaro/metrics_renaming
branch
3 times, most recently
from
b8caab8
to
6540b1d
Compare
mgmeier
reviewed
Sep 2, 2024
mgmeier
approved these changes
Sep 2, 2024
jutaro
force-pushed
the
jutaro/metrics_renaming
branch
from
64bf411
to
a1a2bca
Compare
and with type suffix
Fixes for KES metrics and adoption of node version of trace-dispatcher cardano-node: calculate currentKESPeriod differently
jutaro
force-pushed
the
jutaro/metrics_renaming
branch
from
a1a2bca
to
e731543
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 3, 2024
Names of metrics in the new tracing system
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to harmonize the names of metrics in the new tracing system with those in the old tracing system. Additionally, it addresses missing components in the metrics and fixes various errors. Key enhancements include the ability to add a prefix to metrics names from the configuration and the addition of type-specific suffixes to metrics names.
Changes
Harmonization of Metric Names:
Updated metric names in the new tracing system to align with the naming conventions used in the old tracing system.
Completion of Missing Metrics:
Added previously missing parts to the metrics to ensure comprehensive tracking and consistency.
Error Fixes:
Resolved various errors that were present in the metrics system, improving reliability and accuracy.
Trace Dispatcher Enhancements:
Introduced the ability to add a prefix to metric names based on configuration settings.
Added type-specific suffixes (_int, _counter, _real) to metric names for better clarity and differentiation