Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI only #5527

Closed
wants to merge 4 commits into from
Closed

CI only #5527

wants to merge 4 commits into from

Conversation

mgmeier
Copy link
Contributor

@mgmeier mgmeier commented Nov 4, 2023

Description

De-bump ouroboros-network-protocols to 0.5.2, which does not contain the hard-coded, not configurable chain sync idle timeout.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

coot
coot approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgmeier mgmeier added the WIP Work In Progress (cannot be merged yet) label Nov 8, 2023
@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label Dec 29, 2023
@mgmeier
Copy link
Contributor Author

mgmeier commented Feb 6, 2024

Triggering CI for benchmarking should use this branch / PR only: #5663

@mgmeier mgmeier closed this Feb 6, 2024
@mgmeier mgmeier deleted the bench-8.6.0-pre branch May 18, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coot coot coot approved these changes

Assignees
No one assigned
Labels
Stale WIP Work In Progress (cannot be merged yet)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgmeier @coot