Remove base record from Conf #5261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
force-pushed
the
jordan/cardano-testnet-remove-base-from-conf
branch
6 times, most recently
from
0ba10e1
to
24b87d3
Compare
This was referenced May 24, 2023
Jimbo4350
force-pushed
the
jordan/cardano-testnet-remove-base-from-conf
branch
5 times, most recently
from
0ef9242
to
6ab7681
Compare
Jimbo4350
requested review from
dcoutts,
erikd,
newhoggy,
carbolymer,
JaredCorduan and
CarlosLopezDeLara
as code owners
carbolymer
reviewed
Jun 1, 2023
carbolymer
reviewed
Jun 1, 2023
carbolymer
reviewed
Jun 1, 2023
carbolymer
approved these changes
Jun 1, 2023
Jimbo4350
force-pushed
the
jordan/cardano-testnet-remove-base-from-conf
branch
3 times, most recently
from
77c22ee
to
87b0408
Compare
…ProtocolParamsJsonValue Implement default AlonzoGenesis value Implement default ConwayGenesis value
Update hprop_shutdown to generate the requires genesis files and topology file Implement default mainnet topology file
Implement a shelley only default yaml config value
Testnet.Commands.Genesis
Jimbo4350
force-pushed
the
jordan/cardano-testnet-remove-base-from-conf
branch
from
87b0408
to
fc797fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#4598
Checklist
See Runnings tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-8.10.7andghc-9.2.7Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.