Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GHA to upload draft release assets #5214

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Conversation

hamishmack
Copy link
Contributor

Automate generating release binaries for musl/mac/win on every tag to cardano-node repository (similar to how our docker containers work).

@hamishmack hamishmack self-assigned this May 10, 2023
@hamishmack
Copy link
Contributor Author

An example of workflow running is here https://github.com/input-output-hk/cardano-node/actions/runs/4933488682

Copy link
Contributor

@jbgi jbgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but I don't understand why the release binaries don't appear on the release page : https://github.com/input-output-hk/cardano-node/releases/tag/hkm/test-tag-8

@jbgi
Copy link
Contributor

jbgi commented May 11, 2023

This looks good, but I don't understand why the release binaries don't appear on the release page : https://github.com/input-output-hk/cardano-node/releases/tag/hkm/test-tag-8

never mind, it works but the release was deleted (creating it as draft should avoid being in a hurry to delete it).

@jbgi
Copy link
Contributor

jbgi commented May 11, 2023

Wondering though, do we need to upload the artifacts to the build (as double-zip, so not very practical)? Could we just upload to the GH release?

@angerman
Copy link
Contributor

Wondering though, do we need to upload the artifacts to the build (as double-zip, so not very practical)? Could we just upload to the GH release?

I think we should do just release.

I'll discuss a few security concerns with @disassembler tomorrow.

  • do we trust GH runners? Should we have shared runners?
  • do we trust the release action? Should we fork it, audit it?
  • do we want additional backups on S3?
  • do we want to instantiate only on the runners and force realization from a trusted store?

Copy link
Contributor

@jbgi jbgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also need to remove unofficial nix cache.

.github/workflows/release-upload.yaml Outdated Show resolved Hide resolved
.github/workflows/release-upload.yaml Outdated Show resolved Hide resolved
@jbgi
Copy link
Contributor

jbgi commented May 11, 2023

* do we want to instantiate only on the runners and force realization from a trusted store?

we could use something like nix --builders "" --max-jobs 0 to enforce that the binaries come from our trusted cache.

Automate generating release binaries for musl/mac/win on every tag to cardano-node repository.
@hamishmack hamishmack changed the title Add GHA to upload artifacts Add GHA to upload draft release assets Jun 1, 2023
@hamishmack hamishmack marked this pull request as ready for review June 1, 2023 06:34
@disassembler disassembler added this pull request to the merge queue Jun 1, 2023
Merged via the queue into master with commit 93c0307 Jun 1, 2023
@iohk-bors iohk-bors bot deleted the hkm/gha-upload-artifact branch June 1, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants