-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GHA to upload draft release assets #5214
Conversation
An example of workflow running is here https://github.com/input-output-hk/cardano-node/actions/runs/4933488682 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but I don't understand why the release binaries don't appear on the release page : https://github.com/input-output-hk/cardano-node/releases/tag/hkm/test-tag-8
never mind, it works but the release was deleted (creating it as draft should avoid being in a hurry to delete it). |
Wondering though, do we need to upload the artifacts to the build (as double-zip, so not very practical)? Could we just upload to the GH release? |
I think we should do just release. I'll discuss a few security concerns with @disassembler tomorrow.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also need to remove unofficial nix cache.
we could use something like |
Automate generating release binaries for musl/mac/win on every tag to cardano-node repository.
cde75a2
to
1b0025d
Compare
Automate generating release binaries for musl/mac/win on every tag to cardano-node repository (similar to how our docker containers work).