Remove NoImplicitPrelude #4857
Merged
Remove NoImplicitPrelude #4857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newhoggy
changed the title
newhoggy
force-pushed
the
newhoggy/remove-dependency-on-cardano-prelude
branch
from
d60aa4d
to
55bc0e2
Compare
newhoggy
requested review from
Jimbo4350,
a team,
coot,
deepfire,
jutaro,
dcoutts,
erikd,
JaredCorduan and
CarlosLopezDeLara
as code owners
newhoggy
force-pushed
the
newhoggy/remove-dependency-on-cardano-prelude
branch
3 times, most recently
from
64e7a75
to
c341574
Compare
newhoggy
force-pushed
the
newhoggy/remove-dependency-on-cardano-prelude
branch
from
c341574
to
d4a0b1e
Compare
Jimbo4350
approved these changes
Feb 6, 2023
newhoggy
force-pushed
the
newhoggy/remove-dependency-on-cardano-prelude
branch
8 times, most recently
from
8258d22
to
c742dfc
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 8, 2023
4857: Remove NoImplicitPrelude r=newhoggy a=newhoggy Remove from `NoImplicitPrelude` from `cardano-api` `cardano-submit-api` `cardano-cli` `cardano-testnet` `cardano-node-chairman` `cardano-node` and `cardano-git-rev`. Remove dependency on `cardano-prelude` wherever possible. Removed imported of `Cardano.Prelude` where possible (excluding `bench`). Remaining occurrences are those that are still required: * `canonicalDecodePretty` * `canonicalEncodePretty` * `cborError` * `ConvertText (..)` * `FatalError (..)` * `maximumDef` Co-authored-by: John Ky <john.ky@iohk.io>
|
Build failed: |
newhoggy
force-pushed
the
newhoggy/remove-dependency-on-cardano-prelude
branch
from
c742dfc
to
88e6501
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 11, 2023
4857: Remove NoImplicitPrelude r=newhoggy a=newhoggy Remove from `NoImplicitPrelude` from `cardano-api` `cardano-submit-api` `cardano-cli` `cardano-testnet` `cardano-node-chairman` `cardano-node` and `cardano-git-rev`. Remove dependency on `cardano-prelude` wherever possible. Removed imported of `Cardano.Prelude` where possible (excluding `bench`). Remaining occurrences are those that are still required: * `canonicalDecodePretty` * `canonicalEncodePretty` * `cborError` * `ConvertText (..)` * `FatalError (..)` * `maximumDef` Co-authored-by: John Ky <john.ky@iohk.io>
|
Build failed: |
newhoggy
force-pushed
the
newhoggy/remove-dependency-on-cardano-prelude
branch
from
88e6501
to
e33f1f5
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 12, 2023
4857: Remove NoImplicitPrelude r=newhoggy a=newhoggy Remove from `NoImplicitPrelude` from `cardano-api` `cardano-submit-api` `cardano-cli` `cardano-testnet` `cardano-node-chairman` `cardano-node` and `cardano-git-rev`. Remove dependency on `cardano-prelude` wherever possible. Removed imported of `Cardano.Prelude` where possible (excluding `bench`). Remaining occurrences are those that are still required: * `canonicalDecodePretty` * `canonicalEncodePretty` * `cborError` * `ConvertText (..)` * `FatalError (..)` * `maximumDef` Co-authored-by: John Ky <john.ky@iohk.io>
|
Build failed: |
newhoggy
force-pushed
the
newhoggy/remove-dependency-on-cardano-prelude
branch
from
828de77
to
4d46764
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 12, 2023
4857: Remove NoImplicitPrelude r=newhoggy a=newhoggy Remove from `NoImplicitPrelude` from `cardano-api` `cardano-submit-api` `cardano-cli` `cardano-testnet` `cardano-node-chairman` `cardano-node` and `cardano-git-rev`. Remove dependency on `cardano-prelude` wherever possible. Removed imported of `Cardano.Prelude` where possible (excluding `bench`). Remaining occurrences are those that are still required: * `canonicalDecodePretty` * `canonicalEncodePretty` * `cborError` * `ConvertText (..)` * `FatalError (..)` * `maximumDef` Co-authored-by: John Ky <john.ky@iohk.io>
|
Timed out. |
|
bors r+ |
|
Build succeeded: |
iohk-bors
bot
deleted the
newhoggy/remove-dependency-on-cardano-prelude
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove from
NoImplicitPreludefromcardano-apicardano-submit-apicardano-clicardano-testnetcardano-node-chairmancardano-nodeandcardano-git-rev.Remove dependency on
cardano-preludewherever possible.Removed imported of
Cardano.Preludewhere possible (excludingbench). Remaining occurrences are those that are still required:canonicalDecodePrettycanonicalEncodePrettycborErrorConvertText (..)FatalError (..)maximumDef