Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LedgerStateBabbage patter synonym #4577

Conversation

eyeinsky
Copy link
Contributor

(Couldn't test the change because when running cabal build cardano-node I get:

unknown package: cardano-binary (dependency of byron-spec-ledger)

cardano-binary appears to be a package in the cardano-base repository, which is not linked from cardano-node's cabal.project -- is cardano-binary gotten through other means?)

@LudvikGalois
Copy link
Contributor

LudvikGalois commented Oct 28, 2022

Couldn't test the change

You may need to run cabal update from within the repo itself so it can find packages that are hosted on https://input-output-hk.github.io/cardano-haskell-packages.

@eyeinsky
Copy link
Contributor Author

Got it building and fixed remaining issues :)

@eyeinsky
Copy link
Contributor Author

Got stuck adding these lines here:
https://github.com/input-output-hk/cardano-node/pull/4577/files#diff-d737539ff36d894d150936c9ded4e3b9137053c90242225356549b60e17626ccR281-R282

Error:

StakeCredentialHistory.hs:282:100: error:
    • Could not deduce (HasField
                          "_protocolVersion"
                          (cardano-ledger-babbage-0.1.0.0:Cardano.Ledger.Babbage.PParams.PParams
                             (cardano-ledger-babbage-0.1.0.0:Cardano.Ledger.Babbage.BabbageEra
                                StandardCrypto))
                          L.ProtVer)
        arising from a use of ‘getPV’
      from the context: IsCardanoEra era
        bound by a pattern with constructor:
                   BlockInMode :: forall era mode.
                                  IsCardanoEra era =>
                                  Block era -> EraInMode era mode -> BlockInMode mode,
                 in a lambda abstraction
        at StakeCredentialHistory.hs:(257,13)-(259,17)
    • In the expression: getPV ls
      In the first argument of ‘Just’, namely
        ‘(L.nesRu ls, getGoSnapshot ls, getBalances ls, getPV ls)’
      In the expression:
        Just (L.nesRu ls, getGoSnapshot ls, getBalances ls, getPV ls)
    |
282 |                        ("babbage", L.nesEL ls, Just (L.nesRu ls, getGoSnapshot ls, getBalances ls, getPV ls))
    |                                                                                                    ^^^^^^^^

@eyeinsky eyeinsky marked this pull request as draft November 22, 2022 10:59
@eyeinsky
Copy link
Contributor Author

Converted this to draft, should have been from the beginning.

@github-actions
Copy link

github-actions bot commented Jan 7, 2023

This PR is stale because it has been open 45 days with no activity.

@newhoggy
Copy link
Contributor

To be merged in #5001

@newhoggy newhoggy closed this Mar 18, 2023
@newhoggy
Copy link
Contributor

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants