Update cardano-api's TxOut with inline datum #3773
Conversation
Jimbo4350
requested review from
DavidEichmann,
dcoutts,
erikd,
newhoggy,
nc6 and
JaredCorduan
as code owners
Jimbo4350
force-pushed
the
jordan/update-api-txout-with-inlinedatum
branch
from
ba457eb
to
9175e04
Compare
| let ScriptDataHash alonzoDataHash = hashScriptData sd | ||
| in SJust alonzoDataHash | ||
| toAlonzoTxOutDataHash (TxOutDatumInline inlineDatumSupp _sd) = | ||
| case inlineDatumSupp :: InlineDatumSupportedInEra AlonzoEra of {} |
There was a problem hiding this comment.
Can you explain this change?
There was a problem hiding this comment.
Sure, so basically in the AlonzoEra we can have datum hashes or nothing. Whereas in Babbage era we can have inline datums, datum hashes or nothing. Because there is no open type family for datums, I need to define two separate functions that return the correct type based on the era. I've asked the ledger team to define an open type family for datums and they will probably do this after the hardfork. When they do this, we will be able to have a single function that instantiates the correct type based on the ShelleyBasedEra era we feed it.
There was a problem hiding this comment.
case inlineDatumSupp :: InlineDatumSupportedInEra AlonzoEra of {} tells the compiler it's not possible to pattern match TxOutDatumInline because only InlineDatumSupportedInEra BabbageEra exists.
intention of that constructor. That is, TxOutDatumInTx' also adds the datum to the tx's datum map Add additional comments to the TxOutDatumInline constructor
Jimbo4350
force-pushed
the
jordan/update-api-txout-with-inlinedatum
branch
from
9175e04
to
877c794
Compare
|
bors merge |
|
Build succeeded: |
Updates the TxOut data type with the ability to specify an inline datum and propagate the changes throughout the api and cli.