Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cardano-tracer-3712: try Windows tests. #3714

Merged
merged 1 commit into from
Mar 25, 2022
Merged

Conversation

denisshevchenko
Copy link
Contributor

@denisshevchenko denisshevchenko commented Mar 21, 2022

Currently, cardano-tracer still sometimes has problems with Windows tests. It should be investigated deeply and fixed. Particularly, Cardano.Tracer.Test.Logs.Tests is mostly disabled for Windows.

Now, tests are restored.

@denisshevchenko denisshevchenko self-assigned this Mar 21, 2022
@denisshevchenko denisshevchenko force-pushed the cardano-tracer-3712 branch 3 times, most recently from 8bb3bb7 to 2453b22 Compare March 24, 2022 11:27
@denisshevchenko denisshevchenko marked this pull request as ready for review March 24, 2022 15:41
@denisshevchenko denisshevchenko changed the title cardano-tracer-3712: try Windows tests for logs. cardano-tracer-3712: try Windows tests. Mar 24, 2022
Copy link
Contributor

@deepfire deepfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@denisshevchenko, thank you!

iohk-bors bot added a commit that referenced this pull request Mar 24, 2022
3714: cardano-tracer-3712: try Windows tests. r=deepfire a=denisshevchenko

Currently, cardano-tracer still sometimes has problems with Windows tests. It should be investigated deeply and fixed. Particularly, Cardano.Tracer.Test.Logs.Tests is mostly disabled for Windows.

Now, tests are restored.

Co-authored-by: Denis Shevchenko <denis.shevchenko@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 24, 2022

Build failed:

@denisshevchenko
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Mar 24, 2022
3714: cardano-tracer-3712: try Windows tests. r=denisshevchenko a=denisshevchenko

Currently, cardano-tracer still sometimes has problems with Windows tests. It should be investigated deeply and fixed. Particularly, Cardano.Tracer.Test.Logs.Tests is mostly disabled for Windows.

Now, tests are restored.

Co-authored-by: Denis Shevchenko <denis.shevchenko@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 24, 2022

Build failed:

@denisshevchenko
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 25, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 9c991b0 into master Mar 25, 2022
@iohk-bors iohk-bors bot deleted the cardano-tracer-3712 branch March 25, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants