Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cardano-cli query kes-period-info: Always display metrics #3683

Merged
merged 1 commit into from
Mar 31, 2022
Merged

cardano-cli query kes-period-info: Always display metrics #3683

merged 1 commit into from
Mar 31, 2022

Conversation

cblp
Copy link
Contributor

@cblp cblp commented Mar 4, 2022 •
edited by Jimbo4350
Loading

Resolves #3627

Jimbo4350
Jimbo4350 approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you ask QA to run the command to be sure they are satisfied before merging? And also link the relevant issue in the description?

@cblp cblp changed the title cardano-cli query kes-period-info: Always display metrics (#3627) cardano-cli query kes-period-info: Always display metrics Mar 14, 2022
@saratomaz
Copy link

The metrics are returned, but the values are not correct, already exist a PR that fix that: #3697.
Ideally both of the PRs should be accepted at the same time, like that we can truly test everything related to these metrics.

@Jimbo4350
Copy link
Contributor

The metrics are returned, but the values are not correct, already exist a PR that fix that: #3697. Ideally both of the PRs should be accepted at the same time, like that we can truly test everything related to these metrics.

We will still merge this as I won't get to implementing tests for #3697 until Wednesday

@Jimbo4350
Copy link
Contributor

bors r+

iohk-bors bot added a commit that referenced this pull request Mar 14, 2022
@iohk-bors @cblp
Merge #3683
45c7b9f 
3683: cardano-cli query kes-period-info: Always display metrics r=Jimbo4350 a=cblp

Resolves #3627 

Co-authored-by: Yuriy Syrovetskiy <yuriy.syrovetskiy@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 14, 2022

Build failed:

@Jimbo4350
Copy link
Contributor

bors r+

iohk-bors bot added a commit that referenced this pull request Mar 22, 2022
@iohk-bors @cblp
Merge #3683
e5067d9 
3683: cardano-cli query kes-period-info: Always display metrics r=Jimbo4350 a=cblp

Resolves #3627 

Co-authored-by: Yuriy Syrovetskiy <yuriy.syrovetskiy@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 22, 2022

Build failed:

@Jimbo4350
Copy link
Contributor

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 31, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 3b587d1 into master Mar 31, 2022
@iohk-bors iohk-bors bot deleted the kes-period-info-always branch March 31, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newhoggy newhoggy newhoggy approved these changes

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@saratomaz saratomaz saratomaz approved these changes

@DavidEichmann DavidEichmann Awaiting requested review from DavidEichmann

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@nc6 nc6 Awaiting requested review from nc6

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Always display the metrics dict in the output of kes-period-info command
4 participants
@cblp @saratomaz @Jimbo4350 @newhoggy