Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tracer config mismatches #3668

Merged
merged 3 commits into from
Mar 1, 2022
Merged

Fix tracer config mismatches #3668

merged 3 commits into from
Mar 1, 2022

Conversation

jbgi
Copy link
Contributor

@jbgi jbgi commented Mar 1, 2022 •
edited by disassembler
Loading

Tracer mismatches, among which was mempool which has known performance impacts.

closes #3663

@weebl2000 weebl2000 mentioned this pull request Mar 1, 2022
Closed
@weebl2000
Copy link

This will hopefully fix #3663

@Jimbo4350
Fix proxyLastToEither so that any tracer mismatches
26677a9 
in cardano-node results in a compiler error.
@Jimbo4350
Copy link
Contributor

bors r+

iohk-bors bot added a commit that referenced this pull request Mar 1, 2022
@iohk-bors @jbgi @Jimbo4350
Merge #3668
590a3e5 
3668: Fix tracer config mismatches r=Jimbo4350 a=jbgi

Tracer mismatches, among which was mempool which has known performance impacts.

closes #3663 

Co-authored-by: Jean-Baptiste Giraudeau <jean-baptiste.giraudeau@iohk.io>
Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
@Jimbo4350
Copy link
Contributor

bors r-

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 1, 2022

Canceled.

@Jimbo4350
Copy link
Contributor

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 1, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 36a3c0f into release/1.34 Mar 1, 2022
@btbf btbf mentioned this pull request Mar 4, 2022
Closed
@deepfire deepfire deleted the tracer-config-fix branch May 24, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denisshevchenko denisshevchenko denisshevchenko approved these changes

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@DavidEichmann DavidEichmann Awaiting requested review from DavidEichmann

@dcoutts dcoutts Awaiting requested review from dcoutts dcoutts is a code owner

@erikd erikd Awaiting requested review from erikd erikd is a code owner

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@nc6 nc6 Awaiting requested review from nc6 nc6 is a code owner

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@deepfire deepfire Awaiting requested review from deepfire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbgi @weebl2000 @Jimbo4350 @denisshevchenko