-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tx-generator: Use multiple named wallets #3638
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcFontaine
force-pushed
the
mafo/tx-gen-named-wallets
branch
from
March 3, 2022 14:33
129c0ab
to
c3bffcf
Compare
MarcFontaine
requested review from
denisshevchenko,
jutaro and
cleverca22
as code owners
March 3, 2022 15:12
MarcFontaine
force-pushed
the
mafo/tx-gen-named-wallets
branch
4 times, most recently
from
March 7, 2022 15:04
50e564c
to
a6a57a1
Compare
In high level mode the nix module does not compile a lowlevel tx-generator script. Instead the service options are passed directly to tx-generator and the tx-generator takes care of the high-level to low-level translation. The tx-generator supports two new commands: * json_highlevel: run the tx-generator with flat nix-service options. * compile: compile flat config (in JSON) to a benchmarking script.
tx-generator script can now use multiple named wallets to control which UTxO is spend in which benchmarking phase. Before all UTxOs were managed in a single wallet.
MarcFontaine
force-pushed
the
mafo/tx-gen-named-wallets
branch
from
March 8, 2022 11:08
a6a57a1
to
a36e340
Compare
deepfire
approved these changes
Mar 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
Build succeeded: |
This was referenced Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the tx-generator to use multiple named wallets (instead of one global wallet).
This makes it easier to control which UTxO is used when, inside tx-generator scripts.