Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cardano-cli transaction view: Add friendly certificate printing #3377

Merged
merged 1 commit into from
Apr 19, 2022
Merged

cardano-cli transaction view: Add friendly certificate printing #3377

merged 1 commit into from
Apr 19, 2022

Conversation

cblp
Copy link
Contributor

@cblp cblp commented Nov 19, 2021 •
edited
Loading

Fix #2386

Jimbo4350
Jimbo4350 requested changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right direction but a few comments.

cardano-api/src/Cardano/Api/Address.hs Outdated Show resolved Hide resolved
cardano-api/src/Cardano/Api/Address.hs Outdated Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/Run/Friendly.hs Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/Run/Friendly.hs Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/Run/Friendly.hs Outdated Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/Run/Friendly.hs Outdated Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/Run/Friendly.hs Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/Run/Friendly.hs Outdated Show resolved Hide resolved
@cblp cblp requested a review from Jimbo4350 December 24, 2021 14:20
Jimbo4350
Jimbo4350 requested changes Dec 31, 2021
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there

cardano-api/src/Cardano/Api/Address.hs Outdated Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/Run/Friendly.hs Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/Run/Friendly.hs Outdated Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/Run/Friendly.hs Outdated Show resolved Hide resolved
Jimbo4350
Jimbo4350 requested changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small changes

cardano-cli/src/Cardano/CLI/Run/Friendly.hs Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/Run/Friendly.hs Outdated Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/Run/Friendly.hs Outdated Show resolved Hide resolved
@cblp cblp force-pushed the cblp/tx-view-certificates branch 2 times, most recently from 854d753 to 0ff4432 Compare January 24, 2022 14:18
@cblp cblp force-pushed the cblp/tx-view-certificates branch from 3ea1a98 to 3fb571d Compare March 14, 2022 17:12
@cblp
Copy link
Contributor Author

cblp commented Mar 23, 2022

bors merge

iohk-bors bot added a commit that referenced this pull request Mar 23, 2022
@iohk-bors @cblp
Merge #3377
96047b7 
3377: cardano-cli transaction view: Add friendly certificate printing r=cblp a=cblp

Fix #2386

Co-authored-by: Yuriy Syrovetskiy <yuriy.syrovetskiy@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 23, 2022

Build failed:

@cblp cblp force-pushed the cblp/tx-view-certificates branch 2 times, most recently from de97624 to 1c59259 Compare April 11, 2022 15:05
@cblp cblp force-pushed the cblp/tx-view-certificates branch from 1c59259 to 9fa7963 Compare April 15, 2022 19:14
@cblp
Copy link
Contributor Author

cblp commented Apr 18, 2022

bors merge

iohk-bors bot added a commit that referenced this pull request Apr 18, 2022
@iohk-bors @cblp
Merge #3377
7b6e66e 
3377: cardano-cli transaction view: Add friendly certificate printing r=cblp a=cblp

Fix #2386

Co-authored-by: Yuriy Syrovetskiy <yuriy.syrovetskiy@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 18, 2022

Timed out.

@cblp
Copy link
Contributor Author

cblp commented Apr 19, 2022

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 19, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit feb3812 into master Apr 19, 2022
@iohk-bors iohk-bors bot deleted the cblp/tx-view-certificates branch April 19, 2022 12:22
@dorin100 dorin100 mentioned this pull request Jun 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@DavidEichmann DavidEichmann Awaiting requested review from DavidEichmann

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@nc6 nc6 Awaiting requested review from nc6

@newhoggy newhoggy Awaiting requested review from newhoggy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] - cardano-node transaction view doesn't format certificates well
2 participants
@cblp @Jimbo4350