refactor: review "smoke" marker

Make sure that the "smoke" marker is used only on individual tests, not on class or module level.
IntersectMBO · Sep 30, 2024 · 3d3b304 · 3d3b304
1 parent 6451000
commit 3d3b304
Show file tree

Hide file tree

Showing 48 changed files with 427 additions and 99 deletions.
diff --git a/cardano_node_tests/tests/test_addr_registration.py b/cardano_node_tests/tests/test_addr_registration.py
@@ -61,12 +61,12 @@ def pool_users_disposable(
     return pool_users
 
 
-@pytest.mark.smoke
 class TestRegisterAddr:
     """Tests for stake address registration and deregistration."""
 
     @allure.link(helpers.get_vcs_link())
     @common.PARAM_USE_BUILD_CMD
+    @pytest.mark.smoke
     @pytest.mark.testnets
     @pytest.mark.dbsync
     def test_deregister_registered(
@@ -194,6 +194,7 @@ def _build_dereg() -> clusterlib.TxRawOutput:
 
     @allure.link(helpers.get_vcs_link())
     @common.PARAM_USE_BUILD_CMD
+    @pytest.mark.smoke
     @pytest.mark.testnets
     @pytest.mark.dbsync
     def test_addr_registration_deregistration(
@@ -287,6 +288,7 @@ def test_addr_registration_deregistration(
     @allure.link(helpers.get_vcs_link())
     @submit_utils.PARAM_SUBMIT_METHOD
     @common.PARAM_USE_BUILD_CMD
+    @pytest.mark.smoke
     @pytest.mark.testnets
     @pytest.mark.dbsync
     def test_addr_registration_certificate_order(
@@ -378,11 +380,11 @@ def test_addr_registration_certificate_order(
             assert user_registered.stake.address in tx_db_record.stake_deregistration
 
 
-@pytest.mark.smoke
 class TestNegative:
     """Tests that are expected to fail."""
 
     @allure.link(helpers.get_vcs_link())
+    @pytest.mark.smoke
     @pytest.mark.testnets
     def test_registration_cert_with_wrong_key(
         self,
@@ -406,6 +408,7 @@ def test_registration_cert_with_wrong_key(
         assert "Expected: StakeVerificationKeyShelley" in err_msg, err_msg
 
     @allure.link(helpers.get_vcs_link())
+    @pytest.mark.smoke
     @pytest.mark.testnets
     def test_register_addr_with_wrong_key(
         self,
@@ -444,6 +447,7 @@ def test_register_addr_with_wrong_key(
 
     @allure.link(helpers.get_vcs_link())
     @common.PARAM_USE_BUILD_CMD
+    @pytest.mark.smoke
     @pytest.mark.testnets
     def test_deregister_not_registered_addr(
         self,