Even more CDDL #5382
Open
Even more CDDL #5382
+641
−487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aniketd
changed the base branch from
master
to
aniketd/more-cddl-deduplication
aniketd
force-pushed
the
aniketd/even-more-cddl
branch
from
c3b9ed7 to
6fda464
Compare
aniketd
force-pushed
the
aniketd/even-more-cddl
branch
from
888e696 to
ea10f9d
Compare
* Rename and move metadata, matadatum and metadatum_label definitions to core, along with transaction_index. * Remove metadata_hash and just use auxiliary_data_hash everywhere.
Rename era-name-prefixed definitions with meaningful structural names that are easier to reuse.
* Make native_script fields era-prefixed as and when they are introduced * Add smart constructors for script types in core * Fix script_n_of_k for eras after allegra
aniketd
force-pushed
the
aniketd/even-more-cddl
branch
from
ea10f9d to
472c126
Compare
lehins
approved these changes
Nov 3, 2025
| | 1. metadata (raw) - Supported since Shelley | ||
| | 2. auxiliary_data_array - Array format, introduced in Allegra | ||
| | 3. auxiliary_data_map - Tagged map format, introduced in Alonzo | ||
| | Dijkstra adds plutus_v4_script support at index 5 |
There was a problem hiding this comment.
It is a zero based index: so element 5 but index 4 😉
Suggested change
| | Dijkstra adds plutus_v4_script support at index 5 | |
| | Dijkstra adds plutus_v4_script support at index 4 |
Comment on lines
+407
to
+421
| mkInvalidBefore :: Named Group | ||
| mkInvalidBefore = | ||
| comment | ||
| [str|Timelock validity intervals are half-open intervals [a, b). | ||
| |This field specifies the left (included) endpoint a. | ||
| |] | ||
| $ "invalid_before" =:~ grp [4, a slot] | ||
|
|
||
| mkInvalidHereafter :: Named Group | ||
| mkInvalidHereafter = | ||
| comment | ||
| [str|Timelock validity intervals are half-open intervals [a, b). | ||
| |This field specifies the right (excluded) endpoint b. | ||
| |] | ||
| $ "invalid_hereafter" =:~ grp [5, a slot] |
There was a problem hiding this comment.
For consistency sake we should use the same prefix for CDDL and constructor functions
Suggested change
| mkInvalidBefore :: Named Group | |
| mkInvalidBefore = | |
| comment | |
| [str|Timelock validity intervals are half-open intervals [a, b). | |
| |This field specifies the left (included) endpoint a. | |
| |] | |
| $ "invalid_before" =:~ grp [4, a slot] | |
| mkInvalidHereafter :: Named Group | |
| mkInvalidHereafter = | |
| comment | |
| [str|Timelock validity intervals are half-open intervals [a, b). | |
| |This field specifies the right (excluded) endpoint b. | |
| |] | |
| $ "invalid_hereafter" =:~ grp [5, a slot] | |
| mkScriptInvalidBefore :: Named Group | |
| mkScriptInvalidBefore = | |
| comment | |
| [str|Timelock validity intervals are half-open intervals [a, b). | |
| |This field specifies the left (included) endpoint a. | |
| |] | |
| $ "script_invalid_before" =:~ grp [4, a slot] | |
| mkScriptInvalidHereafter :: Named Group | |
| mkScriptInvalidHereafter = | |
| comment | |
| [str|Timelock validity intervals are half-open intervals [a, b). | |
| |This field specifies the right (excluded) endpoint b. | |
| |] | |
| $ "script_invalid_hereafter" =:~ grp [5, a slot] |
|
|
||
| ### `testlib` | ||
|
|
||
| * Add CDDL definitions for `script_hash`, `mkScriptPubkey`, `mkScriptAll`, `mkScriptAny`, `mkScriptNOfK`, `mkInvalidBefore`, `mkInvalidHereafter` |
There was a problem hiding this comment.
Ditto
Suggested change
| * Add CDDL definitions for `script_hash`, `mkScriptPubkey`, `mkScriptAll`, `mkScriptAny`, `mkScriptNOfK`, `mkInvalidBefore`, `mkInvalidHereafter` | |
| * Add CDDL definitions for `script_hash`, `mkScriptPubkey`, `mkScriptAll`, `mkScriptAny`, `mkScriptNOfK`, `mkScriptInvalidBefore`, `mkScriptInvalidHereafter` |
| metadata = {* metadatum_label => metadatum} | ||
|
|
||
| transaction_metadatum_label = uint | ||
| metadatum_label = uint .size 8 |
There was a problem hiding this comment.
Nice catch on fixing the width of this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses some more of the checklist in #5367 and is the third part of #5194
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).