Remove all deprecated functionality introduced before the latest release #5376
+136
−930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deleting code is great 😄 I assume the changelog doesn't need adjusting since this was all previously marked as changed/removed? |
lehins
requested changes
Oct 29, 2025
There was a problem hiding this comment.
This is an awesome cleanup!
Unfortunately, we do need to mention all of the things that were removed by this PR in changelogs 😢
Moreover, any package that had anything removed needs a major version bump, if it didn't already have one, because any removal is considered a breaking change according to PVP.
f-f
force-pushed
the
f-f/fix-5371
branch
2 times, most recently
from
9e75aed to
5d20c68
Compare
|
@lehins I have updated all the relevant changelogs so this should be ready for another look |
lehins
approved these changes
Oct 31, 2025
|
Needs a rebase on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #5371
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
Versions updated in.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
Version bounds in.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).