Skip to content

Conversation

@neilmayhew
Copy link
Contributor

@neilmayhew neilmayhew commented Oct 21, 2025

Description

Some of the remaining BabbageFeatures duplicate tests that are already present in the Conway testlib, and some of them should be moved to the Babbage testlib.

Closes #4183

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@neilmayhew neilmayhew force-pushed the nm/4183-babbagefeatures-to-imp branch 5 times, most recently from 705f149 to 4733357 Compare October 23, 2025 04:21
@neilmayhew neilmayhew force-pushed the nm/4183-babbagefeatures-to-imp branch from 4733357 to a3299c6 Compare October 30, 2025 00:43
@neilmayhew neilmayhew marked this pull request as ready for review October 30, 2025 00:44
@neilmayhew neilmayhew requested a review from a team as a code owner October 30, 2025 00:44
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice de-duplication and wonderful to get rid of BabbageFeatures!

@neilmayhew neilmayhew force-pushed the nm/4183-babbagefeatures-to-imp branch from a3299c6 to c818c8a Compare November 3, 2025 16:12
@neilmayhew neilmayhew enabled auto-merge November 3, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Translate all tests from BabbageFeatures to Imp test

3 participants