Skip to content

Conversation

@teodanciu
Copy link
Contributor

@teodanciu teodanciu commented May 19, 2025

to main library

Closes #5003

Description

These are all the instances which have Annotator equivalent.
LEFT means: the instance was left in the main lib, usually because it was there before the addition of the non-annotator one
MOVED means: the instance was moved to testlib

binary 
	PV1.Data                     DONE, LEFT
core 
	BootstrapWitness             DONE, LEFT
	WitVKey kr                   DONE, LEFT
	MemoBytes t era              DONE, LEFT - existed
	PlutusData era               DONE, LEFT
	Data era                     DONE, LEFT
	PlutusBinary                 DONE, LEFT - existed before
	Block h era                  DONE, MOVED
tpraos 
	BHeader c                    DONE, MOVED
shelley 
	ShelleyTxRaw era             DONE, MOVED
	ShelleyTx era                DONE, MOVED
	ShelleyTxSeq era             DONE, MOVED
	MultiSig era                 DONE, MOVED
	MultiSigRaw era              DONE, MOVED
	ShelleyTxAuxDataRaw era      DONE, LEFT
	ShelleyTxAuxData era         DONE, MOVED
	ShelleyTxBodyRaw era         DONE, LEFT
	ShelleyTxBody era            DONE, MOVED
	ShelleyTxWitsRaw era         DONE, MOVED
	ShelleyTxWits era            DONE, MOVED
	LaxBlock h era               N/A (removed)
allegra 
	AllegraTxBodyRaw () era      DONE, LEFT
	AllegraTxBody era            DONE, MOVED
	TimelockRaw era              DONE, MOVED
	Timelock era                 DONE, MOVED
	AllegraTxAuxDataRaw era      DONE, MOVED
	AllegraTxAuxData era         DONE, MOVED
mary 
	MaryTxBodyRaw era            DONE, N/A because it's AllegraTxBodyRaw
	MaryTxBody era               DONE, MOVED
alonzo 
	AlonzoTxBody era             DONE, MOVED
	AlonzoTxBodyRaw era          DONE, LEFT
	AlonzoTxSeq era              DONE, MOVED
	AlonzoScript era             DONE, MOVED
	AlonzoTx era                 DONE, MOVED
	AlonzoTxAuxDataRaw era       DONE, MOVED
	AlonzoTxAuxData era          DONE, MOVED
	TxDatsRaw era                DONE, MOVED
	TxDats era                   DONE, MOVED
	RedeemersRaw era             DONE, MOVED
	Redeemers era                DONE, MOVED
	AlonzoTxWitsRaw era          DONE, MOVED
	AlonzoTxWits era             DONE, MOVED
	TranslationInstance era      N/A
babbage
	BabbageTxBody era            DONE, MOVED
	BabbageTxBodyRaw era         DONE, LEFT
conway
	ConwayTxBodyRaw era          DONE, LEFT
	ConwayTxBody era             DONE, MOVED

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@teodanciu teodanciu force-pushed the td/reinstate-annotator-instances branch 11 times, most recently from 5ab127e to 4575d15 Compare May 21, 2025 16:51
@teodanciu teodanciu force-pushed the td/reinstate-annotator-instances branch 4 times, most recently from 97087c4 to 7e7162f Compare May 23, 2025 22:30
@teodanciu teodanciu force-pushed the td/reinstate-annotator-instances branch from 7e7162f to 61aeb25 Compare May 23, 2025 23:35
@teodanciu teodanciu force-pushed the td/reinstate-annotator-instances branch from 61aeb25 to 497779c Compare May 23, 2025 23:52
@teodanciu teodanciu changed the title [wip] - Reinstate Annotator instances to main libs Reinstate Annotator instances to main libs May 23, 2025
@teodanciu teodanciu marked this pull request as ready for review May 23, 2025 23:53
@teodanciu teodanciu requested a review from a team as a code owner May 23, 2025 23:53
@teodanciu teodanciu force-pushed the td/reinstate-annotator-instances branch from 497779c to 5df0db4 Compare May 23, 2025 23:54
teodanciu added 3 commits May 24, 2025 00:56
except for `Raw` types wrapped in MemoBytes: `ShelleyTxAuxDataRaw`,
`ShelleyTxBodyRaw`, `AllegraTxBodyRaw`, `AlonzoTxBodyRaw`,
`BabbageTxBodyRaw`, `ConwayTxBodyRaw`
@teodanciu teodanciu force-pushed the td/reinstate-annotator-instances branch from 5df0db4 to adc1d1c Compare May 23, 2025 23:56
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!
Thank you for taking care of this task!

@lehins lehins merged commit 12acadc into master May 24, 2025
128 checks passed
@lehins lehins deleted the td/reinstate-annotator-instances branch May 24, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revert Annotator removal

3 participants