-
Notifications
You must be signed in to change notification settings - Fork 166
Reinstate Annotator instances to main libs
#5056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5ab127e to
4575d15
Compare
97087c4 to
7e7162f
Compare
7e7162f to
61aeb25
Compare
in `translateEraThroughCBOR`
in the same way as it was done for `RedeemersRaw` deserializer
61aeb25 to
497779c
Compare
Annotator instances to main libsAnnotator instances to main libs
497779c to
5df0db4
Compare
except for `Raw` types wrapped in MemoBytes: `ShelleyTxAuxDataRaw`, `ShelleyTxBodyRaw`, `AllegraTxBodyRaw`, `AlonzoTxBodyRaw`, `BabbageTxBodyRaw`, `ConwayTxBodyRaw`
5df0db4 to
adc1d1c
Compare
lehins
approved these changes
May 24, 2025
Collaborator
lehins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
Thank you for taking care of this task!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to main library
Closes #5003
Description
These are all the instances which have
Annotatorequivalent.LEFTmeans: the instance was left in the main lib, usually because it was there before the addition of the non-annotator oneMOVEDmeans: the instance was moved to testlibChecklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).