Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metadata validation, hash checking, and URL support to stake-pool registration-certificate, and hash checking and URL support to stake-pool metadata-hash #932

Merged
merged 13 commits into from
Oct 11, 2024
Merged

Add metadata validation, hash checking, and URL support to stake-pool registration-certificate, and hash checking and URL support to stake-pool metadata-hash #932

merged 13 commits into from
Oct 11, 2024

Conversation

palas
Copy link
Contributor

@palas palas commented Oct 9, 2024 •
edited
Loading

Changelog

- description: |
    Added metadata, metadata hash validation and URL support to `stake-pool registration-certificate`; and hash checking and URL support to `stake-pool metadata-hash`.
  type:
  - feature        # introduces a new feature
  - test           # fixes/modifies tests

Context

This is part of the work to address #882.

This PR adds and optional check to stake-pool registration-certificate to verify that the hash input matches metadata given in a particular URL.

It also adds URL support to stake-pool metadata-hash for consistency with other hashing commands (see #895, and #927).

How to trust this PR

There are plenty of tests and code reuse. Most of the changes are also tests and changes to golden files, the actual code changes are few and very similar to the ones in previous PRs.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas added enhancement New feature or request test Modifies/extends the test suite labels Oct 9, 2024
@palas palas self-assigned this Oct 9, 2024
@palas palas linked an issue Oct 9, 2024 that may be closed by this pull request
[FR] - Add File Hash Validation when Building Transaction #882
Closed
@palas palas marked this pull request as ready for review October 9, 2024 20:59
palas and others added 3 commits October 10, 2024 20:00
@palas
Unify code in pExpectedHash, pExpectedDrepMetadataHash, and `pExp…
67a0d7f 
…ectedStakePoolMetadataHash`
@palas @smelc
Fix instructions in comment
c68d32c 
Co-authored-by: Clément Hurlin <smelc@users.noreply.github.com>
@palas
Remove toUrl function
ddfa0a2
@palas palas requested a review from smelc October 10, 2024 18:21
@palas palas added this pull request to the merge queue Oct 11, 2024
Merged via the queue into main with commit a3f93bc Oct 11, 2024
25 checks passed
@palas palas deleted the add-hash-validation4 branch October 11, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smelc smelc smelc approved these changes

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350 Jimbo4350 is a code owner

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@carbolymer carbolymer Awaiting requested review from carbolymer carbolymer is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

Assignees

@palas palas

Labels
enhancement New feature or request test Modifies/extends the test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] - Add File Hash Validation when Building Transaction
2 participants
@palas @smelc