Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compatible command group #917

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Add compatible command group #917

wants to merge 13 commits into from
+4,294 −20

Conversation

Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Sep 26, 2024 •
edited
Loading

Related: #926

Changelog

- description: |
    Introduce "compatible" command group
  type:
  - feature        # introduces a new feature
  - compatible     # the API has changed but is non-breaking

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@Jimbo4350 Jimbo4350 force-pushed the jordan/expose-compatible-command branch 3 times, most recently from c7f4302 to 903a192 Compare October 2, 2024 20:53
@Jimbo4350 Jimbo4350 force-pushed the jordan/expose-compatible-command branch from 903a192 to 8e4b6f4 Compare October 16, 2024 18:27
@Jimbo4350 Jimbo4350 changed the title Jordan/expose compatible command Add compatible command group Oct 16, 2024
@Jimbo4350 Jimbo4350 force-pushed the jordan/expose-compatible-command branch 6 times, most recently from 8bb861d to 65486f9 Compare October 17, 2024 14:39
@Jimbo4350 Jimbo4350 marked this pull request as ready for review October 17, 2024 14:39
@Jimbo4350 Jimbo4350 force-pushed the jordan/expose-compatible-command branch from 65486f9 to 5b37288 Compare October 17, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@carbolymer carbolymer Awaiting requested review from carbolymer carbolymer is a code owner

@smelc smelc Awaiting requested review from smelc smelc is a code owner

@palas palas Awaiting requested review from palas palas is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Jimbo4350