Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cardano-api (fix estimation units issue with proposing and certifying scripts) #841

Conversation

Jimbo4350
Copy link
Contributor

Changelog

- description: |
  Bump cardano-api (fix estimation units issue with proposing and certifying scripts)
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

CarlosLopezDeLara and others added 10 commits July 16, 2024 15:20
This change requires a new release from cardano-api since the change is not included on the tag cardano-api-9.0.0.0

remove srp
The simplified hashDRepMetadata no longer checks for the size of the DRep metadata, instead it only return the hash of the file given by the user.

Remove no longer needed errors.
preserve old test
add new test for cip119
Copy link

github-actions bot commented Sep 1, 2024

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label Sep 1, 2024
@Jimbo4350 Jimbo4350 closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants