Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed nix build #446

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Fixed nix build #446

merged 1 commit into from
Nov 9, 2023

Conversation

coot
Copy link
Contributor

@coot coot commented Nov 8, 2023 •
edited
Loading

No description provided.

@coot coot marked this pull request as ready for review November 8, 2023 17:51
@coot coot requested review from lehins and angerman November 8, 2023 17:51
@coot
Copy link
Contributor Author

coot commented Nov 9, 2023

@lehins there's an unrelated to this PR nothunk test failure on Windows.

@lehins
Copy link
Collaborator

lehins commented Nov 9, 2023

there's an unrelated to this PR nothunk test failure on Windows.

Yeah, I've seen it before. It would be nice to get a reproducible example, but the failure doesn't provide us with this opportunity.

However, it looks like it happens on NoThunks test, so I am not gonna worry too much about it.

@lehins lehins enabled auto-merge November 9, 2023 16:45
@lehins lehins merged commit 33ba914 into master Nov 9, 2023
21 checks passed
@lehins lehins deleted the coot/fix-nix branch November 9, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehins lehins lehins approved these changes

@angerman angerman Awaiting requested review from angerman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coot @lehins