Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent BLS Affine values from being coerced. #420

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Prevent BLS Affine values from being coerced. #420

merged 1 commit into from
Jun 28, 2023

Conversation

tdammers
Copy link
Contributor

The same safeguard already existed for the Point type, but we also need it for Affine.

@tdammers tdammers requested a review from lehins June 26, 2023 11:25
lehins
lehins approved these changes Jun 27, 2023
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely a good idea.
Affine seems to be an internal type, so I guess we can consider this as an internal safety measure and thus not a breaking or even a user visible change.

@tdammers @lehins
Prevent BLS Affine values from being coerced.
78e5d3f 
The same safeguard already existed for the Point type, but we also need
it for Affine.
@lehins lehins force-pushed the tdammers/bls-affine-nominal branch from 0d20b30 to 78e5d3f Compare June 28, 2023 08:55
@lehins lehins enabled auto-merge June 28, 2023 08:56
@lehins lehins merged commit 3bd707e into master Jun 28, 2023
@lehins lehins deleted the tdammers/bls-affine-nominal branch June 28, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehins lehins lehins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdammers @lehins