Implement writeTxFileTextEnvelope and writeTxFileTextEnvelopeCanonical for SignedTx
#1033
+191
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
requested review from
CarlosLopezDeLara,
carbolymer,
dcoutts,
disassembler,
erikd,
kevinhammond,
newhoggy and
palas
as code owners
Jimbo4350
force-pushed
the
jordan/add-write-text-envelope-functions-for-signed-tx
branch
from
00d933e to
292cdc0
Compare
Jimbo4350
force-pushed
the
jordan/add-write-text-envelope-functions-for-signed-tx
branch
from
292cdc0 to
fee95da
Compare
palas
approved these changes
Nov 21, 2025
Contributor
palas
left a comment
palas
left a comment
There was a problem hiding this comment.
Just a few comments. Make sure the potential incompatibility issue is not a problem, and the rest are only suggestions
Comment on lines
+75
to
+87
| serialiseToRawBytes (SignedTx tx) = | ||
| Ledger.serialize' (Ledger.eraProtVerHigh @(LedgerEra era)) tx | ||
| deserialiseFromRawBytes _ = | ||
| bimap wrapError SignedTx | ||
| . Ledger.decodeFullAnnotator | ||
| (Ledger.eraProtVerHigh @(LedgerEra era)) | ||
| "SignedTx" | ||
| Ledger.decCBOR | ||
| . fromStrict | ||
| where | ||
| wrapError | ||
| :: Ledger.DecoderError -> SerialiseAsRawBytesError | ||
| wrapError = SerialiseAsRawBytesError . displayException |
Contributor
There was a problem hiding this comment.
I think this can probably be implemented in terms of SerialiseAsCBOR now, or the other way around, because they are almost identical code except for the error handling
| . fromStrict | ||
|
|
||
| instance (L.EraTx (LedgerEra era), HasTypeProxy era) => HasTextEnvelope (SignedTx era) where | ||
| textEnvelopeType _ = "Tx" |
Contributor
There was a problem hiding this comment.
This may break compatibility with the old API text envelope type:
Contributor
There was a problem hiding this comment.
Also, do you have in mind how will deserialising work without knowing the era? I guess because we have only two eras is not too problematic, but we may need two separate functions (one for each era).
Comment on lines
+53
to
+61
| either | ||
| ( \err -> | ||
| error $ | ||
| "writeTxFileTextEnvelopeCanonical: Impossible - deserialisation of just serialised bytes failed " | ||
| <> show err | ||
| ) | ||
| id | ||
| . canonicaliseCborBs | ||
| $ teRawCBOR te |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist