Edits to CMakeLists.txt to use existing Raspbian binaries for SDL2 and SDL2 Mixer #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CMakeLists.txt file has been edited so that Shockolate can be compiled on Raspbian Buster without needing to run ./build_deps.sh and will instead use the binaries for SDL2 and SDL2 mixer as provided by the Raspbian repository. This is a major time saver when compiling Shockolate on the Raspberry Pi. This in turn should mean that Shockolate will compile on Debian without any issues in a few weeks when Debian Buster is released. Here's the changes I've made: -Removed the m32 compiler flags since Raspbian's compiler does not recognize it. - Changed the find_library command for SDL2 to find_package. - Removed NO_DEFAULT_PATH from the find_command for SDL2 Mixer.
|
This breaks the builds for the rest of the platforms, so we should probably add this in as a CMake Option to toggle this behavior specifically for Raspberry Pi builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CMakeLists.txt file has been edited so that Shockolate can be compiled on Raspbian Buster without needing to run ./build_deps.sh and will instead use the binaries for SDL2 and SDL2 mixer as provided by the Raspbian repository. This is a major time saver when compiling Shockolate on the Raspberry Pi. This in turn should mean that Shockolate will compile on Debian without any issues in a few weeks when Debian Buster is released.
Here's the changes I've made:
-Removed the m32 compiler flags since Raspbian's compiler does not recognize it.