Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Metis deployment page #816

Conversation

m-appel
Copy link
Member

@m-appel m-appel commented Jul 5, 2024

Missing import caused the page to not be displayed. Probably a regression from c3eb1d1.

Motivation and Context

Fixes #815.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Missing import caused the page to not be displayed.
Probably a regression from c3eb1d1.

Fixes InternetHealthReport#815.
Copy link
Member

@romain-fontugne romain-fontugne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@romain-fontugne romain-fontugne merged commit b51969f into InternetHealthReport:master Jul 5, 2024
3 checks passed
dpgiakatos added a commit that referenced this pull request Jul 8, 2024
Rebase dev from master
dpgiakatos added a commit that referenced this pull request Aug 30, 2024
* gsoc24 init (#798)

* Added basic ripe atlas API plugin

* Added v-network-graph and basic traceroute visualization

* added basic styling

* Added some position fixes for nodes

* Added Basic UI components

* Network Topology Basic UI Init

* Added RIS Live WebSocket Connection

* Filtering and Storing RIS Live Messages

* Added Iyp query and Basic visualization using Dagre

* Added BGP Graph Data

* added time range and probe selection

* Hover effect and More customization added

* Added AS Sankey Graph

* Bug fix and Prettier Code Refactored

* added tooltip

* Optimized and removed code redundancy

* Added Messages Table and Filter For Peer AS

* Added more customization to node

* Node size filter added

* Fix Metis deployment page (#816)

Missing import caused the page to not be displayed.
Probably a regression from c3eb1d1.

Fixes #815.

* Added BGP Communities

* Added Route Params and Sorted RRC input options

* added coloring modes

* Modified handleMessages and Communities

* Added Time range

* Removed Code Redundancy and Optimised handleFilterMessages function

* Replaced QRange with QSlider

* Bug fix and Added Reset Option

* Some customization button added

* Added Messages Stats Display Info

* Added "No data" message

* Added No of Messages Received Line Chart

* Prefix added

* Added BGP message type (Announce/Withdraw)

* Added Button Colors

* Added GenericCardController

* Changed Page Layout Order

* Code cleanup

* Added Router Link to Peer and AS Path in the Table

* Added AS Info

* Used utcString() from report plugin

* Props added and some customization

* changed deafult moreSpecific to false

* Chaged Sankey Hover Text

* Click and hover effect updated

* changed "timestampSlider" name and converted line chart to stacked line chart announcements and withdrawals

* fix router

* delete old file

* Added Live Status and Put QSlider inside the line chart

* Added bgp "Unknown" type check

* Added some code formatting

* Reduced sankey layout margin

* Added comments

* fixed rtt coloring

* added get param

* added request caching

* rtt dot

* added rtt legend

* added localstorage caching

* fixed asn container

* added line chart

* added view controls

* minor fix

* fixed duplicate probe issue

* Hide isLive button on init

* Fixed timestamp messages

* Added more BGP Monitor Info card text

* Added Fill Color in BGP Monitor line chart

* Added stackgroup property in line chart

* Grid Layout Added

* Url support added

* url format change

* added proper destination selection

* added search to destinations table

* bug fix on dest selection

* added some extra debounce

* typo

* Fit Screen Fix

* minor styling fixes

* Remove Consecutive Duplicate AS

* added localstorage cache clearing

* added default last 24h on time range

* Added description

* Added Nodes and Links Count in Sankey Graph

* Added ws disconnected dialog

* Replace cache function with IHR cache function

* Rename router url

* Add chart in separate component

* Add line chart in separate component

* Add probes table in separate component

* Add destinations table in separate component

* fix cd

* Create subcomponent

* fix url parameter

* fix css

* ui changes

* Fix router and add text

* Fix text in menu

* change router

* fix bugs

* reset cache on full storage

* add space in card

---------

Co-authored-by: lean <tmeletlidis@protonmail.com>
Co-authored-by: Arnab Ghosh <arnabsonu2@gmail.com>
Co-authored-by: 0xAnon <utkarshshail005@protonmail.com>
Co-authored-by: mtashiro <malte@iij.ad.jp>
dpgiakatos added a commit that referenced this pull request Aug 30, 2024
* gsoc24 init (#798)

* Added basic ripe atlas API plugin

* Added v-network-graph and basic traceroute visualization

* added basic styling

* Added some position fixes for nodes

* Added Basic UI components

* Network Topology Basic UI Init

* Added RIS Live WebSocket Connection

* Filtering and Storing RIS Live Messages

* Added Iyp query and Basic visualization using Dagre

* Added BGP Graph Data

* added time range and probe selection

* Hover effect and More customization added

* Added AS Sankey Graph

* Bug fix and Prettier Code Refactored

* added tooltip

* Optimized and removed code redundancy

* Added Messages Table and Filter For Peer AS

* Added more customization to node

* Node size filter added

* Fix Metis deployment page (#816)

Missing import caused the page to not be displayed.
Probably a regression from c3eb1d1.

Fixes #815.

* Added BGP Communities

* Added Route Params and Sorted RRC input options

* added coloring modes

* Modified handleMessages and Communities

* Added Time range

* Removed Code Redundancy and Optimised handleFilterMessages function

* Replaced QRange with QSlider

* Bug fix and Added Reset Option

* Some customization button added

* Added Messages Stats Display Info

* Added "No data" message

* Added No of Messages Received Line Chart

* Prefix added

* Added BGP message type (Announce/Withdraw)

* Added Button Colors

* Added GenericCardController

* Changed Page Layout Order

* Code cleanup

* Added Router Link to Peer and AS Path in the Table

* Added AS Info

* Used utcString() from report plugin

* Props added and some customization

* changed deafult moreSpecific to false

* Chaged Sankey Hover Text

* Click and hover effect updated

* changed "timestampSlider" name and converted line chart to stacked line chart announcements and withdrawals

* fix router

* delete old file

* Added Live Status and Put QSlider inside the line chart

* Added bgp "Unknown" type check

* Added some code formatting

* Reduced sankey layout margin

* Added comments

* fixed rtt coloring

* added get param

* added request caching

* rtt dot

* added rtt legend

* added localstorage caching

* fixed asn container

* added line chart

* added view controls

* minor fix

* fixed duplicate probe issue

* Hide isLive button on init

* Fixed timestamp messages

* Added more BGP Monitor Info card text

* Added Fill Color in BGP Monitor line chart

* Added stackgroup property in line chart

* Grid Layout Added

* Url support added

* url format change

* added proper destination selection

* added search to destinations table

* bug fix on dest selection

* added some extra debounce

* typo

* Fit Screen Fix

* minor styling fixes

* Remove Consecutive Duplicate AS

* added localstorage cache clearing

* added default last 24h on time range

* Added description

* Added Nodes and Links Count in Sankey Graph

* Added ws disconnected dialog

* Replace cache function with IHR cache function

* Rename router url

* Add chart in separate component

* Add line chart in separate component

* Add probes table in separate component

* Add destinations table in separate component

* fix cd

* Create subcomponent

* fix url parameter

* fix css

* ui changes

* Fix router and add text

* Fix text in menu

* change router

* fix bugs

* reset cache on full storage

* add space in card

---------

Co-authored-by: lean <tmeletlidis@protonmail.com>
Co-authored-by: Arnab Ghosh <arnabsonu2@gmail.com>
Co-authored-by: 0xAnon <utkarshshail005@protonmail.com>
Co-authored-by: mtashiro <malte@iij.ad.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metis deployment page disappeared
2 participants