Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 806 - Missing y-label in network report chart #807

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

RyanNgoDev
Copy link
Contributor

@RyanNgoDev RyanNgoDev commented Jun 12, 2024

Description

  • Added y-label for prefix tags chart
  • Fixed chart layout not updated when adding y-label or other properties
  • This fix covers similar cases using y-label (which were not showed). Eg: ''Upstream'' ASes chart below
    image

Motivation and Context

Fix Issue #806

How Has This Been Tested?

Tested on local machine

Screenshots (if appropriate):

image
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@RyanNgoDev RyanNgoDev changed the base branch from master to dev June 12, 2024 19:18
@dpgiakatos dpgiakatos self-requested a review June 13, 2024 07:13
Copy link
Member

@dpgiakatos dpgiakatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dpgiakatos dpgiakatos merged commit 87c8b33 into InternetHealthReport:dev Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants