Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: Integrate IODA Charts in Country and Network Reports #724

Conversation

mohamedawnallah
Copy link
Member

@mohamedawnallah mohamedawnallah commented Dec 31, 2023

Description

This PR integrates IODA Charts in Country and Network Reports.

Motivation and Context

https://github.com/orgs/InternetHealthReport/discussions/31

How Has This Been Tested?

Please check the IODA Alarms Test cases in the GitHub CI job result:
https://github.com/InternetHealthReport/ihr-website/actions/runs/7371850572/job/20059617876

Recordings

Screen.Recording.2023-12-31.at.7.37.15.PM.mov

Additional Context

This PR depends on this PR #717

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@dpgiakatos dpgiakatos mentioned this pull request Jan 1, 2024
6 tasks
@dpgiakatos dpgiakatos self-requested a review January 9, 2024 12:26
@dpgiakatos
Copy link
Member

I will review this pull request after the merge of PR #717.

Copy link
Member

@dpgiakatos dpgiakatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request aims to add IODA charts to country and network report pages. The author has implemented this new feature, and the functionalities are working without errors. Therefore, this pull request can be merged into the master branch.

@romain-fontugne
Copy link
Member

Thanks, this is a great addition! I think a more explicit text than 'AS Internet Overview' is needed but I'll fix this after the merge.

@romain-fontugne romain-fontugne merged commit 9e5fcdb into InternetHealthReport:master Jan 10, 2024
2 checks passed
dpgiakatos pushed a commit to dpgiakatos/ihr-website that referenced this pull request Jan 10, 2024
romain-fontugne pushed a commit that referenced this pull request Mar 1, 2024
* Add IYP search & change networks route

* Add IYP AS page

* Add IYP IXP page

* Flat IYP table

* bug fixed

* Add IYP Prefix page

* fix ipv6 prefix

* Add IYP tags page

* Add IYP Domain Name page

* Integrate AS report page with IYP page

* Add event listener in treemaps

* Comment out language switcher from header

* Add IYP country page & fix search & fix routes

* fix route in country overview

* Upgrade packages

* Merge #724

* Add doc and change IYP legend route to IYP

* fix headings and overview padding

* Increase expandable bars headline

* Docs updated

* Remove unnecessary comments

* Add ip-address lib which replaces prefix regex

* Replace variables in cypher queries when displayed

* AS new layout init

* ASOverview added in new layout

* Add date filter in AS layout

* Init Generic Card Controller

* Monitor tab completed in new layout

* Add ASPeers in new layout

* Routing tab completed

* DNS tab completed

* Peering tab completed

* Registration tab completed

* Prototype for the new AS network layout completed

* fix bug in locale url init

* fix bug in url set after search as network

* As layout can select widget in custom tab

* Add day report to widgets

* Country new layout added

* Prefix new layout init

* Prefix new layout completed

* Host Name completed & Tag custom init

* Tag new layout completed

* Add hast name and tag pages to menu

* Add metadata in iyp views dynamically

* Fix metadata reference time and url in layout

* Add func to copy cypher query

* Fix metadata cypher dynamic query

* Add anchor tag to each widget

* Add links from the overview to the widgets

* Init Ranking page

* Add Rank page

* Fix style in cypher btn & limit rank res to 100K

* fix websocket in iyp

* Init transforming IYP websocket to HTTP req

* Replace neo4j driver with HTTP requests

* Fix scroll to anchor

* Fix routing with active tab

* IXP new layout completed

* fix location search bar in network delay

* Bug fixes

* Convert DomaiName node to HostName

* Add redirection from the old locale

* Add Dockerfile and deploy instruction on README.md

* Add github action to test docker image

* Creating new UI for loading page

* Update metadata table info

* Add margin between logo in loading page

* Add version badge to footer logo

* Fix layout and update readme

* Update readme

* Bug fixes and UI improvements

* Fix originated column in prefix overview

* Remove links from overview indexes, update Prominent query, fix AS tag chart

* Bug fixes in tag's treemap chart

* Apply PR #713 to Host Name, Tag and Rank pages

* Fix top rank in network overview & replace Host Name to Hostname

---------

Co-authored-by: Dimitrios Panteleimon Giakatos <dgiakatos@csd.auth.gr>
romain-fontugne added a commit that referenced this pull request Mar 1, 2024
* Fixed Examples In Network and Countries page (#713)

* Integrating IYP to IHR (#719)

* Add IYP search & change networks route

* Add IYP AS page

* Add IYP IXP page

* Flat IYP table

* bug fixed

* Add IYP Prefix page

* fix ipv6 prefix

* Add IYP tags page

* Add IYP Domain Name page

* Integrate AS report page with IYP page

* Add event listener in treemaps

* Comment out language switcher from header

* Add IYP country page & fix search & fix routes

* fix route in country overview

* Upgrade packages

* Merge #724

* Add doc and change IYP legend route to IYP

* fix headings and overview padding

* Increase expandable bars headline

* Docs updated

* Remove unnecessary comments

* Add ip-address lib which replaces prefix regex

* Replace variables in cypher queries when displayed

* AS new layout init

* ASOverview added in new layout

* Add date filter in AS layout

* Init Generic Card Controller

* Monitor tab completed in new layout

* Add ASPeers in new layout

* Routing tab completed

* DNS tab completed

* Peering tab completed

* Registration tab completed

* Prototype for the new AS network layout completed

* fix bug in locale url init

* fix bug in url set after search as network

* As layout can select widget in custom tab

* Add day report to widgets

* Country new layout added

* Prefix new layout init

* Prefix new layout completed

* Host Name completed & Tag custom init

* Tag new layout completed

* Add hast name and tag pages to menu

* Add metadata in iyp views dynamically

* Fix metadata reference time and url in layout

* Add func to copy cypher query

* Fix metadata cypher dynamic query

* Add anchor tag to each widget

* Add links from the overview to the widgets

* Init Ranking page

* Add Rank page

* Fix style in cypher btn & limit rank res to 100K

* fix websocket in iyp

* Init transforming IYP websocket to HTTP req

* Replace neo4j driver with HTTP requests

* Fix scroll to anchor

* Fix routing with active tab

* IXP new layout completed

* fix location search bar in network delay

* Bug fixes

* Convert DomaiName node to HostName

* Add redirection from the old locale

* Add Dockerfile and deploy instruction on README.md

* Add github action to test docker image

* Creating new UI for loading page

* Update metadata table info

* Add margin between logo in loading page

* Add version badge to footer logo

* Fix layout and update readme

* Update readme

* Bug fixes and UI improvements

* Fix originated column in prefix overview

* Remove links from overview indexes, update Prominent query, fix AS tag chart

* Bug fixes in tag's treemap chart

* Apply PR #713 to Host Name, Tag and Rank pages

* Fix top rank in network overview & replace Host Name to Hostname

---------

Co-authored-by: Dimitrios Panteleimon Giakatos <dgiakatos@csd.auth.gr>

---------

Co-authored-by: Arnab Ghosh <arnabsonu2@gmail.com>
Co-authored-by: Dimitrios Panteleimon Giakatos <36899728+dpgiakatos@users.noreply.github.com>
Co-authored-by: Dimitrios Panteleimon Giakatos <dgiakatos@csd.auth.gr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants