return BadRequest for all invlid inputs#4291
Open
lvhan028 wants to merge 3 commits intoInternLM:mainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts OpenAI-compatible API validation to return 400 Bad Request for invalid inputs, and expands request parameter validation.
Changes:
- Add validation for
min_prange in generate/completions/chat-completions request checks. - Add validation for non-positive
max_tokens/max_completion_tokens(andmin_new_tokensfor chat). - Change FastAPI
RequestValidationErrorhandling from HTTP 422 to HTTP 400; refactor OpenAI protocol model typing.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| lmdeploy/serve/openai/serving_generate.py | Validate min_p range for /generate inputs. |
| lmdeploy/serve/openai/serving_completion.py | Validate max_tokens/max_completion_tokens positivity and min_p range for /v1/completions. |
| lmdeploy/serve/openai/serving_chat_completion.py | Validate max_tokens/max_completion_tokens/min_new_tokens and min_p range for /v1/chat/completions. |
| lmdeploy/serve/openai/protocol.py | Refactor protocol type annotations; narrows chat messages typing. |
| lmdeploy/serve/openai/api_server.py | Return HTTP 400 (instead of 422) for request validation errors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.