Skip to content

support do_preprocess=False for chat.completions #3645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lmdeploy/serve/openai/api_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,8 @@ async def chat_completions_v1(raw_request: Request = None):
]
else:
tools = [item.function.model_dump() for item in request.tools]
# text completion for string input
do_preprocess = False if isinstance(request.messages, str) else request.do_preprocess
result_generator = VariableInterface.async_engine.generate(
request.messages,
request.session_id,
Expand All @@ -427,7 +429,7 @@ async def chat_completions_v1(raw_request: Request = None):
stream_response=True, # always use stream to enable batching
sequence_start=True,
sequence_end=True,
do_preprocess=not isinstance(request.messages, str), # text completion for string input
do_preprocess=do_preprocess,
adapter_name=adapter_name,
enable_thinking=request.enable_thinking,
)
Expand Down
1 change: 1 addition & 0 deletions lmdeploy/serve/openai/protocol.py
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ class ChatCompletionRequest(BaseModel):
user: Optional[str] = None
response_format: Optional[ResponseFormat] = Field(default=None, examples=[None]) # noqa
# additional argument of lmdeploy
do_preprocess: Optional[bool] = True
repetition_penalty: Optional[float] = 1.0
session_id: Optional[int] = -1
ignore_eos: Optional[bool] = False
Expand Down