Skip to content

Use the DOI field to build missing URL for bibliography.json file. #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

MattHeffron
Copy link
Contributor

When URL field is missing in Zotero json data, use the DOI field to build a URL for the bibliography.json file.
Add debugging/collections/tags/types files generation under conditionals in scripts/update_bibliography.sh.
This includes the PR #210 changes.
See also the discussion in Issue #1534

…he bibliography.json file.

Add debugging file generation under conditionals in update_bibliography.sh
@stumbo
Copy link
Member

stumbo commented Sep 30, 2024

Matt - I ran your updated script and the output, bibliography.json no longer works with our site. I assume there are some changes that need to be reflected in layouts/shortcodes/bibTable.html. I haven't had a chance to look any deeper into the issue.

@MattHeffron
Copy link
Contributor Author

Matt - I ran your updated script and the output, bibliography.json no longer works with our site. I assume there are some changes that need to be reflected in layouts/shortcodes/bibTable.html. I haven't had a chance to look any deeper into the issue.

This works on my system, so what should I update locally (Hugo?) to try to reproduce this failure?
(I will be off-line until about October 11.)

@stumbo
Copy link
Member

stumbo commented Sep 30, 2024

I'll dig deeper over the next few days. We can sync up when you're back online.

@stumbo
Copy link
Member

stumbo commented Oct 1, 2024

I spent a little time and ended up merging this into my staging branch - it appears to have deployed correctly.  You can go to https://stumbo.github.io/InterlispDraft.github.io/history/bibliography/ to see the bibliography built with this PR (#242)  and my updates for robots.txt.  PR (#239)

Copy link
Member

@stumbo stumbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on successfully deploying to staging site.  The 1991 classic, PEPYS: Generating Autobiographies by Automatic Tracking appears to be a case where a url was missing and the doi was used to build a working url.  It works correctly in the newly build bibliography.

@MattHeffron MattHeffron merged commit d785162 into main Oct 1, 2024
@MattHeffron MattHeffron deleted the mth2-use-DOI-for-url-bibliography branch October 1, 2024 05:55
MattHeffron added a commit that referenced this pull request Oct 1, 2024
….sh is run.

I forgot to turn it off before committing the mth2-use-DOI-for-url-bibliography branch, and creating the PR #242.
stumbo pushed a commit that referenced this pull request Oct 1, 2024
….sh is run. (#243)

I forgot to turn it off before committing the mth2-use-DOI-for-url-bibliography branch, and creating the PR #242.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants