Add URL query #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add some extra logic into the main function to handle failures of AKD/S and fall back to URL.
This makes it possible to specify both an AKD/S record and URL at the same time but refuse failover to URL if AKD/S fails.
thomotron
force-pushed
the
feature/query-url
branch
from
bbdf9d9 to
7fd4c04
Compare
thomotron
commented
Jun 22, 2022
thomotron
force-pushed
the
feature/query-url
branch
from
260564e to
2883217
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a pair of config options that specify a URL to pull keys from and whether to allow fallback to URL if AKD/S fails.
Config entries
This adds the following new config entries:
url: The URL to pull keys fromallowUrlFallback: Whether to allow pulling keys fromurlif pulling from AKD/S failsCloses #4