Replace oneDPL with Dispatch on macOS#11
Closed
ruberith wants to merge 1 commit intoInteractiveComputerGraphics:masterfrom
ruberith:fix-macos
Closed
Replace oneDPL with Dispatch on macOS#11ruberith wants to merge 1 commit intoInteractiveComputerGraphics:masterfrom ruberith:fix-macos
ruberith wants to merge 1 commit intoInteractiveComputerGraphics:masterfrom
ruberith:fix-macos
Conversation
Contributor
Author
|
Since #10 has been merged, this isn't needed anymore. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since oneDPL dropped support for C++11 and broke for recent versions of libc++, I'd propose to remove the external dependency and use Apple's Dispatch library on macOS.
Alternatively, #10 works just as well. 🙂