Skip to content

Adblock Plus "Disable on this Site only" with wrong detection (sometimes) #1

Open

Description

@christianhaller

Hi,
the detection is not reliable, when the user has Adblock Plus (2.7.2) running in the mode "Disable on this page" only.

In the gif, you can see the race condition.

abp-bug

Actual result:
inconsistent

Expected result:
"Adblock is disabled"

Firefox 45, OS X 10.11.14

Activity

  1. christianhaller commented on Apr 20, 2016

    @christianhaller
    Author
  2. iabmayank commented on Jun 27, 2016

    @iabmayank
    Contributor

    The script has been updated with the fix. Please checkout the latest code.
    Note: The analytics script along with the fix will be update soon.

  3. marttihalme commented on Jun 29, 2016

    @marttihalme

    Hi,
    what was actually changed or fixed?

    Br,
    Martti
    Alma Media Finland

    From: Mayank Mishra [mailto:notifications@github.com]
    Sent: 27. kesäkuuta 2016 18:36
    To: InteractiveAdvertisingBureau/AdBlockDetection AdBlockDetection@noreply.github.com
    Subject: Re: [InteractiveAdvertisingBureau/AdBlockDetection] Adblock Plus "Disable on this Site only" with wrong detection (sometimes) (#1)

    The script has been updated with the fix. Please checkout the latest code.
    Note: The analytics script along with the fix will be update soon.

    —
    You are receiving this because you are subscribed to this thread.
    Reply to this email directly, view it on GitHubhttps://github.com//issues/1#issuecomment-228783217, or mute the threadhttps://github.com/notifications/unsubscribe/AKhDGaRsxurQ3IDt8b8KHGZFh3SS1432ks5qP-3sgaJpZM4ILo6E.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions