Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MEC011 Data Structure Refactoring #322

Merged
merged 12 commits into from
Nov 22, 2021
Merged

MEC011 Data Structure Refactoring #322

merged 12 commits into from
Nov 22, 2021

Conversation

dilallkx
Copy link
Collaborator

CHANGES:

  • Sandbox Controller Applications API:
    • Removed unused API parameters (e.g. version, state)
    • Added Persist parameter to indicate if application should be flushed on scenario termination
    • Regenerated code
  • New meep-applications package:
    • Used by Sandbox Controller to create/update/delete application instances
    • Used by MEC011 & MEC021 to obtain list of application instances
  • ETSI MEC Services:
    • Fixed app termination code
  • App Enablement:
    • Modifications to follow new data structure
    • Integration with meep-applications package
    • Integration with meep-subscriptions package
    • Code cleanup
  • Sandbox Controller:
    • Integration with meep-applications package

TESTING:

  • UT & system tests pass

@dilallkx dilallkx changed the title MEC011 Refactoring MEC011 Data Structure Refactoring Nov 15, 2021
@dilallkx dilallkx self-assigned this Nov 15, 2021
@dilallkx dilallkx added bug Something isn't working enhancement New feature or request labels Nov 15, 2021
@dilallkx dilallkx requested review from pastorsx and roymx and removed request for pastorsx November 15, 2021 21:22
roymx
roymx requested changes Nov 17, 2021
View reviewed changes
go-apps/meep-sandbox-ctrl/api/swagger.yaml Show resolved Hide resolved
go-packages/meep-data-model/api/swagger.yaml Show resolved Hide resolved
go-packages/meep-sandbox-ctrl-client/api/swagger.yaml Show resolved Hide resolved
go-packages/meep-sandbox-ctrl-client/api/swagger.yaml Show resolved Hide resolved
js-packages/meep-sandbox-ctrl-client/src/api/ApplicationsApi.js Show resolved Hide resolved
go-apps/meep-sandbox-ctrl/server/app-ctrl.go Show resolved Hide resolved
go-packages/meep-applications/application-store.go Show resolved Hide resolved
go-packages/meep-applications/application-store.go Show resolved Hide resolved
go-packages/meep-data-model/model_application_info.go Show resolved Hide resolved
go-packages/meep-sandbox-ctrl-client/api_applications.go Show resolved Hide resolved
dilallkx added a commit to dilallkx/AdvantEDGE that referenced this pull request Nov 22, 2021
@dilallkx
review follow-up for PR InterDigitalInc#322
ae1597f
@roymx
Copy link
Collaborator

roymx commented Nov 22, 2021

OK, can merge

@dilallkx dilallkx merged commit b03c3ca into InterDigitalInc:develop Nov 22, 2021
@dilallkx dilallkx deleted the kd_sp45_mec_svc_fixes branch November 22, 2021 16:53
dilallkx added a commit to dilallkx/AdvantEDGE that referenced this pull request Nov 23, 2021
@dilallkx
review follow-up for PR InterDigitalInc#322
4cf2017
@dilallkx dilallkx mentioned this pull request Nov 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roymx roymx roymx requested changes

Assignees

@dilallkx dilallkx

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dilallkx @roymx