Skip to content

Conversation

zyxkad
Copy link
Collaborator

@zyxkad zyxkad commented Jan 26, 2025

  • fix smart glasses position should be eye position but not feet position
  • rename getWorldPos -> getPhysicsPos
  • add IPeripheralOwner.getHoldingEntity
  • remove item.copy()s refactor fingerprint generator
  • refactor DistanceDetector
  • fix registeriation
  • fix smartglass direction
  • abstract peripheral ticker
  • fix data storage for smartglass and save distance detector data in smartglass

PLEASE READ THE GUIDELINES BEFORE MAKING A CONTRIBUTION

  • Please check if the PR fulfills these requirements
  • The commit message are well described
  • Docs have been added / updated (for features or maybe bugs which were noted). If not, please update the needed documentation here. Feel free to remove this check if you don't need it
  • All changes have fully been tested
  • What kind of change does this PR introduce? (Bug fix, feature, ...)
    Feature

  • What is the new behavior (if this is a feature change)?
    Allow entity use distance detector in smart glasses (but without laser)

  • Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)
    Uhhh

  • Other information:
    Is it a good idea to get the targeting block / entity info? (with geo/environment scanner for sure)

    And yes this PR is mainly just make distance detector work with smart glasses but I do not know why I change that much

Copy link
Contributor

Build Preview

badge

You can find files attached to the below linked Workflow Run URL (Logs).

Name Link
Commit 99e967f
Logs https://github.com/IntelligenceModding/AdvancedPeripherals/actions/runs/12971683202
Jar Files AdvancedPeripherals PR 705
Expires At 2025-04-26T05:11:27Z

@zyxkad zyxkad requested a review from SirEndii January 26, 2025 05:21
@zyxkad zyxkad added this to the 0.8r milestone Jan 26, 2025
Copy link
Member

@SirEndii SirEndii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't complain, looks good to me

@SirEndii SirEndii merged commit a32365a into IntelligenceModding:dev/0.8 Jan 26, 2025
4 checks passed
@zyxkad zyxkad deleted the smartglass-patch branch January 26, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants