-
Notifications
You must be signed in to change notification settings - Fork 6
feat: Adds sitemap generation #753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BenjaminMichaelis
wants to merge
4
commits into
main
Choose a base branch
from
sitemapGeneration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements sitemap generation to improve SEO. Adds a new service to extract static routes from the application's controllers and actions. These routes are then used, along with content-based routes, to generate a sitemap.xml file in the wwwroot directory during application startup. This helps search engines crawl and index the site more effectively.
Ensures the initial logger is used when warning about a missing Application Insights connection string. This provides a more accurate representation of the application's startup phase.
Updates the test class to use the correct WebApplicationFactory type. This ensures proper dependency injection and test setup.
Keboo
reviewed
Jul 11, 2025
Refactors sitemap XML generation to use a dedicated service for route configuration. This change improves the sitemap generation process by: - Introducing `IRouteConfigurationService` to centralize route retrieval and filtering logic. - Excluding Identity, Index, and Error routes from the sitemap. - Adding tests to validate sitemap generation. - Configuring the base URL for sitemap generation through configuration. - Ensuring sitemap health by validating canonical links. This approach provides better control over the routes included in the sitemap and enhances the overall maintainability and testability of the sitemap generation process.
a652da9
to
b06a9ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements sitemap generation instead of taking a generated sitemap from tooling.
DotnetSitemapGenerator
package for creating sitemap XML.Part 1 of #754