Skip to content

Add executables for xml to md #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

BenjaminMichaelis
Copy link
Member

  • Add executables so that the source code doesn't need to be built every time I want to convert the xml to the md file
  • Renamed the folders so that it is a clear distinguishment between the source code and the executable by adding -src and -exe to the end of the folder names

This way you don't have to build the program everytime
Rename to include src at the end to distinguish clearly from exe
Copy link
Member

@Keboo Keboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think we want to do this. Binaries quickly bloat got repositories so it is typically bad practice to check them in. A better solution could be for us to build up CLI and publish it as a dotnet tool

@BenjaminMichaelis
Copy link
Member Author

Okay, I probably won't tackle that right now as I would have to do some reading to figure out how to do that, unless there's some quick things to look at, I'll try to take a look at some point.

@BenjaminMichaelis
Copy link
Member Author

Created ability for nupkg in #157 instead

@BenjaminMichaelis BenjaminMichaelis deleted the BenjaminMichaelis-OfflineXMLtoMDexe branch March 6, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants