Skip to content

Issue #127: remove obsolete exception #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/Guidelines(8th Edition).xml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
<guideline key="Ch05_cab2aca" severity="AVOID" section="Coding" subsection="Exceptions">AVOID explicitly throwing exceptions from finally blocks. (Implicitly thrown exceptions resulting from method calls are acceptable.)</guideline>
<guideline key="Ch05_34bdd36" severity="DO" section="Coding" subsection="Exceptions">DO favor try/finally and avoid using try/catch for cleanup code.</guideline>
<guideline key="Ch05_888a64e" severity="DO" section="Coding" subsection="Exceptions">"DO throw exceptions that describe which exceptional circumstance occurred, and if possible, how to prevent it."</guideline>
<guideline key="Ch05_79a6a92" severity="AVOID" section="Coding" subsection="Exceptions">AVOID general catch blocks and replace them with a catch of System.Exception.</guideline>
<guideline key="Ch05_75f9029" severity="AVOID" section="Coding" subsection="Exceptions">AVOID catching exceptions for which the appropriate action is unknown. It is better to let an exception go unhandled than to handle it incorrectly.</guideline>
<guideline key="Ch05_0f98c19" severity="AVOID" section="Coding" subsection="Exceptions">"AVOID catching and logging an exception before rethrowing it. Instead, allow the exception to escape until it can be handled appropriately."</guideline>
<guideline key="Ch05_6f18913" severity="DO" section="Coding" subsection="Exceptions">DO prefer using an empty throw when catching and rethrowing an exception so as to preserve the call stack.</guideline>
Expand Down
1 change: 0 additions & 1 deletion docs/coding/csharp.md
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@
- :no_entry: AVOID explicitly throwing exceptions from finally blocks. (Implicitly thrown exceptions resulting from method calls are acceptable.)
- :heavy_check_mark: DO favor try/finally and avoid using try/catch for cleanup code.
- :heavy_check_mark: DO throw exceptions that describe which exceptional circumstance occurred, and if possible, how to prevent it.
- :no_entry: AVOID general catch blocks and replace them with a catch of System.Exception.
- :no_entry: AVOID catching exceptions for which the appropriate action is unknown. It is better to let an exception go unhandled than to handle it incorrectly.
- :no_entry: AVOID catching and logging an exception before rethrowing it. Instead, allow the exception to escape until it can be handled appropriately.
- :heavy_check_mark: DO prefer using an empty throw when catching and rethrowing an exception so as to preserve the call stack.
Expand Down