Updated C# guidelines #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamskt
reviewed
Aug 26, 2020
There was a problem hiding this comment.
I think we should use a different emojii for "CONSIDER: " rules, so they are visually different. @Keboo , @MarkMichaelis thoughts?
Keboo
reviewed
Sep 3, 2020
Updated guidelines
fixed grammar errors
Update csharp.md Update csharp.md Update csharp.md Update csharp.md Update csharp.md Update csharp.md Update csharp.md Update csharp.md Update csharp.md Update csharp.md Update csharp.md Update csharp.md Update csharp.md Update csharp.md Update csharp.md Update csharp.md Update csharp.md Update csharp.md fixed typo change consider emoji to be grey question mark Update csharp.md Update docs/coding/csharp.md Co-authored-by: Kevin B <Keboo@users.noreply.github.com> Update docs/coding/csharp.md Co-authored-by: Kevin B <Keboo@users.noreply.github.com> Update docs/coding/csharp.md Co-authored-by: Kevin B <Keboo@users.noreply.github.com> Update docs/coding/csharp.md Co-authored-by: Kevin B <Keboo@users.noreply.github.com> Update docs/coding/csharp.md Co-authored-by: Kevin B <Keboo@users.noreply.github.com> Update docs/coding/csharp.md Co-authored-by: Kevin B <Keboo@users.noreply.github.com> Update docs/coding/csharp.md Co-authored-by: Kevin B <Keboo@users.noreply.github.com> Update docs/coding/csharp.md Co-authored-by: Kevin B <Keboo@users.noreply.github.com> Update csharp.md Update csharp.md
Keboo
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@MarkMichaelis @adamskt @Keboo
Updated the csharp.md file to have the new guidelines, and added links to different sections headers. The other file updated was an image file that I used to see what examples might look like.