Repository navigation
fix: empty/fill of water or lava buckets against plot edges - #4945
Open
florianreuth wants to merge 1 commit into
Open
florianreuth wants to merge 1 commit into
florianreuth wants to merge 1 commit into
Conversation
Fixes IntellectualSites#4832 Signed-off-by: Florian Reuth <git@florianreuth.de>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Filling buckets bypasses build-height validation without an equivalent check in the fill handler.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Addresses #4832 by moving bucket protection checks to bucket-specific handlers, allowing fluid placement against plot walls and floors.
Changes:
- Exempts water, lava, and empty buckets from generic interaction checks.
- Adds build-height validation when emptying buckets.
| File | Description |
|---|---|
| Bukkit/src/main/java/com/plotsquared/bukkit/listener/PlayerEventListener.java | Adjusts bucket interaction handling and emptying height checks. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+1307
to
+1308
| case "WATER_BUCKET", "LAVA_BUCKET", "BUCKET" -> { | ||
| return; |
Member
There was a problem hiding this comment.
Need to confirm that this definitely isn't handled somewhere else (and adjust if it isn't)
dordsor21
requested changes
Oct 7, 2026
dordsor21
left a comment
dordsor21
left a comment
Member
There was a problem hiding this comment.
Please confirm the copilot comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #4832
Description
Handles BUCKET interactions properly so that they aren't cancelled when targeting plot edges or the plot ground.
Submitter Checklist
@since TODO.