Skip to content

Conversation

@ZECHEESELORD
Copy link
Contributor

Overview

Fixes #3359

Description

Ensure FastSchematicReaderV3 passes an immutable dimensions vector to the clipboard factory so the default pipeline can’t mutate the reader’s state and zero out 1xNx1 schematics, preventing a / by 0 when applying biome data.

Submitter Checklist

  • Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
  • Ensure that the pull request title represents the desired changelog entry.
  • New public fields and methods are annotated with @since TODO.
  • I read and followed the contribution guidelines.

@ZECHEESELORD ZECHEESELORD requested a review from a team as a code owner October 29, 2025 21:27
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Oct 29, 2025
Copy link
Member

@PierreSchwang PierreSchwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, that there was no report of missing clipboard data or arithmetic exceptions yet

@ZECHEESELORD
Copy link
Contributor Author

interesting, that there was no report of missing clipboard data or arithmetic exceptions yet

Yeah, It's an odd edge case that only really blows up when the schematic actually carries biome data

@PierreSchwang
Copy link
Member

interesting, that there was no report of missing clipboard data or arithmetic exceptions yet

Yeah, It's an odd edge case that only really blows up when the schematic actually carries biome data

Ah, I see - doesn't really happen with linear palettes for block data.

@dordsor21 dordsor21 merged commit 9a076e3 into IntellectualSites:main Oct 30, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix This PR fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Loading 1 wide/long schematics with biomes causes / by zero in FastSchematicReaderV3

4 participants