Fix crash due to race condition when calling markUnsaved #3351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Is this missing changes..? Or phone being weird... Otherwise, did the order of the syncTasks matter? We're running in the opposite order now |
Member
|
Ah I see, 1.21.5 and later |
Member
Author
The tasks are mostly independent. We have two tasks regarding entities (removing and adding), but these shouldn't conflict either. |
dordsor21
approved these changes
Oct 25, 2025
NotMyFault
approved these changes
Oct 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #3350
Description
markUnsavedmodifies a collection on Vanilla/Spigot. This can lead to crashes when run off the main thread. Let's just run it where it has to run instead.Also
setLightCorrectcallsmarkUnsaved, so we don't need to do that again.Submitter Checklist
@since TODO.