fix: pasting of colored signs #3244
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #3223
Description
For whatever reason we have two methods to convert from lin tags to nms tags in our adapter. The fix (
add->addAndUnwrap) was added to the fromNative method, but not our super duper custom fromNativeLin method. As it's literally doing the same thing with identical code (though it uses fully qualified imports) I've just delegated to the one upstream contains and uses (and where the fix was added previously).fromNativeLinis used byPaperweightFaweAdapter#blockEntityToCompound(), which is used by CharGetBlocks, yada yada...Submitter Checklist
@since TODO.