Skip to content

Conversation

@PierreSchwang
Copy link
Member

Overview

Fixes #3223

Description

For whatever reason we have two methods to convert from lin tags to nms tags in our adapter. The fix (add -> addAndUnwrap) was added to the fromNative method, but not our super duper custom fromNativeLin method. As it's literally doing the same thing with identical code (though it uses fully qualified imports) I've just delegated to the one upstream contains and uses (and where the fix was added previously).

fromNativeLin is used by PaperweightFaweAdapter#blockEntityToCompound(), which is used by CharGetBlocks, yada yada...

Submitter Checklist

  • Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
  • Ensure that the pull request title represents the desired changelog entry.
  • New public fields and methods are annotated with @since TODO.
  • I read and followed the contribution guidelines.

@PierreSchwang PierreSchwang requested a review from a team as a code owner July 23, 2025 20:52
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Jul 23, 2025
@NotMyFault NotMyFault merged commit 7016f20 into main Jul 26, 2025
9 checks passed
@NotMyFault NotMyFault deleted the fix/coloredSIgnsPaste branch July 26, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix This PR fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Coloured signs don't paste (1.21.5)

5 participants