Skip to content

Conversation

@NoltoxGit
Copy link
Contributor

Overview

This pull request introduces support for Minecraft server version 1.21.8 by updating configuration files, dependencies, and constants. The changes ensure compatibility with the new version while maintaining support for previous versions.

Fixes #3236

Description

  • Updated .github/ISSUE_TEMPLATE/bug_report.yml to include 1.21.8 as a selectable server version in the bug report template.
  • Updated the build.gradle.kts file in the adapter-1_21_6 module to use the Paper dev bundle for version 1.21.8-R0.1.
  • Modified PaperweightAdapter.java to include a check for DATA_VERSION_MC_1_21_8 and updated the error message to reflect support for 1.21.6, 1.21.7, and 1.21.8.
  • Added a new constant DATA_VERSION_MC_1_21_8 with the value 4440 in Constants.java.

Submitter Checklist

  • Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
  • Ensure that the pull request title represents the desired changelog entry.
  • New public fields and methods are annotated with @since TODO.
  • I read and followed the contribution guidelines.

@NoltoxGit NoltoxGit requested a review from a team as a code owner July 17, 2025 15:45
@Athar42
Copy link

Athar42 commented Jul 18, 2025

In the build.gradle.kts, there is at least one mistake :
the().paperDevBundle("1.21.8-R0.1-20250717.225444-12")

This release can't exist, max build for 1.21.8 is 5, so -12 can't be ^^

Source : https://repo.papermc.io/service/rest/repository/browse/maven-public/io/papermc/paper/dev-bundle/1.21.8-R0.1-SNAPSHOT/

So, a more accurate one would be :
the().paperDevBundle("1.21.8-R0.1-20250718.183306-5")

@NoltoxGit
Copy link
Contributor Author

In the build.gradle.kts, there is at least one mistake : the().paperDevBundle("1.21.8-R0.1-20250717.225444-12")

This release can't exist, max build for 1.21.8 is 5, so -12 can't be ^^

Source : https://repo.papermc.io/service/rest/repository/browse/maven-public/io/papermc/paper/dev-bundle/1.21.8-R0.1-SNAPSHOT/

So, a more accurate one would be : the().paperDevBundle("1.21.8-R0.1-20250718.183306-5")

Fixed!

@Athar42
Copy link

Athar42 commented Jul 18, 2025

@Tsoccerguy3 : You are not using the latest commits, you get the failure from the error I reported earlier (and for which he already correct it)

@SarabethIrwys
Copy link

Can you make it possible to export as a Jar File in Action for download?

@NoltoxGit
Copy link
Contributor Author

@PierreSchwang
Copy link
Member

Please cherry-pick EngineHub/WorldEdit@9164c46 and adjust the version check (as done similarly in WorldEdit in a later commit). Not sure if we should reference the WorldEdit docs in the version warning.

@NoltoxGit
Copy link
Contributor Author

Like this @PierreSchwang?

@NoltoxGit
Copy link
Contributor Author

It's good now @PierreSchwang?

Copy link
Member

@PierreSchwang PierreSchwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to work

@PierreSchwang PierreSchwang requested a review from a team July 20, 2025 17:51
Copy link
Member

@SirYwell SirYwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor suggestions

@SirYwell
Copy link
Member

I've questions about your modifications, does I need to delete 1.21.7 everywhere?

No, we still support 1.21.7, but we don't need a special runServer gradle task for that version as we can just run a 1.21.8 server.

@NoltoxGit NoltoxGit requested a review from PierreSchwang July 21, 2025 15:07
@NoltoxGit
Copy link
Contributor Author

I've questions about your modifications, does I need to delete 1.21.7 everywhere?

No, we still support 1.21.7, but we don't need a special runServer gradle task for that version as we can just run a 1.21.8 server.

Oke, good!

@SirYwell
Copy link
Member

Why does it seem like the Coreprotect feature doesn't work with FAWE in this version? You haven't been approved yet.

This PR has nothing to do with CoreProtect.

Copy link
Member

@SirYwell SirYwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to approve even though the CI currently fails due to jitpack issues. The changes look good.

@NoltoxGit
Copy link
Contributor Author

Why does it seem like the Coreprotect feature doesn't work with FAWE in this version? You haven't been approved yet.

Hey @SarabethIrwys,
Surely it's for CoreProtect to update its API or something else, as nothing touches CoreProtect in this PR.
Please get in touch with the developer of this plugin!

@NoltoxGit
Copy link
Contributor Author

Hey,
Normally the problem seems to have been solved, as I've been able to compile it locally!

@NoltoxGit NoltoxGit requested a review from SirYwell July 22, 2025 11:46
@SirYwell SirYwell merged commit 1d1e749 into IntellectualSites:main Jul 24, 2025
11 of 28 checks passed
@SirYwell
Copy link
Member

Thanks @NoltoxGit

@NotMyFault NotMyFault added the Major feature This PR adds a major feature label Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Major feature This PR adds a major feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to support MC 1.21.8

6 participants