-
-
Notifications
You must be signed in to change notification settings - Fork 311
Update Minecraft 1.21.8 #3237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Minecraft 1.21.8 #3237
Conversation
|
In the build.gradle.kts, there is at least one mistake : This release can't exist, max build for 1.21.8 is 5, so -12 can't be ^^ So, a more accurate one would be : |
Fixed! |
|
@Tsoccerguy3 : You are not using the latest commits, you get the failure from the error I reported earlier (and for which he already correct it) |
|
Can you make it possible to export as a Jar File in Action for download? |
|
@SarabethIrwys |
|
Please cherry-pick EngineHub/WorldEdit@9164c46 and adjust the version check (as done similarly in WorldEdit in a later commit). Not sure if we should reference the WorldEdit docs in the version warning. |
Support 1.21.8
Cherry pick from EngineHub/WorldEdit@9164c46
|
Like this @PierreSchwang? |
..._6/src/main/java/com/sk89q/worldedit/bukkit/adapter/ext/fawe/v1_21_6/PaperweightAdapter.java
Outdated
Show resolved
Hide resolved
..._6/src/main/java/com/sk89q/worldedit/bukkit/adapter/ext/fawe/v1_21_6/PaperweightAdapter.java
Outdated
Show resolved
Hide resolved
|
It's good now @PierreSchwang? |
PierreSchwang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems to work
SirYwell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor suggestions
|
Hey @SirYwell, I've questions about your modifications, does I need to delete 1.21.7 everywhere?
|
No, we still support 1.21.7, but we don't need a special runServer gradle task for that version as we can just run a 1.21.8 server. |
Oke, good! |
This PR has nothing to do with CoreProtect. |
SirYwell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to approve even though the CI currently fails due to jitpack issues. The changes look good.
Hey @SarabethIrwys, |
|
Hey, |
|
Thanks @NoltoxGit |
Overview
This pull request introduces support for Minecraft server version 1.21.8 by updating configuration files, dependencies, and constants. The changes ensure compatibility with the new version while maintaining support for previous versions.
Fixes #3236
Description
.github/ISSUE_TEMPLATE/bug_report.ymlto include1.21.8as a selectable server version in the bug report template.build.gradle.ktsfile in theadapter-1_21_6module to use the Paper dev bundle for version1.21.8-R0.1.PaperweightAdapter.javato include a check forDATA_VERSION_MC_1_21_8and updated the error message to reflect support for 1.21.6, 1.21.7, and 1.21.8.DATA_VERSION_MC_1_21_8with the value4440inConstants.java.Submitter Checklist
@since TODO.