fix: some fixes to NMSRelighter #3215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dordsor21
force-pushed
the
fix/nmsrelighter
branch
from
25201a0 to
348fc3e
Compare
dordsor21
force-pushed
the
fix/nmsrelighter
branch
from
348fc3e to
f5f49e0
Compare
NotMyFault
approved these changes
Jun 15, 2025
SirYwell
reviewed
Jun 15, 2025
Comment on lines
+214
to
+215
| Queue<BlockVector3> lightPropagationQueue = new LinkedList<>(); | ||
| Queue<LightRemovalNode> lightRemovalQueue = new LinkedList<>(); |
Member
Author
There was a problem hiding this comment.
We're only ever accessing the front of the queue and we are adding frequently and only to the end. Using array for what is likely to be resized at least once, possibly twice felt less performant
SirYwell
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.