Skip to content

Conversation

@SirYwell
Copy link
Member

Overview

Description

The previous caused errors on startup.

Submitter Checklist

  • Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
  • Ensure that the pull request title represents the desired changelog entry.
  • New public fields and methods are annotated with @since TODO.
  • I read and followed the contribution guidelines.

@SirYwell SirYwell requested a review from a team as a code owner March 25, 2025 13:10
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Mar 25, 2025
@Tsoccerguy3
Copy link

I tried your PR and had a few errors https://athion.net/ISPaster/paste/view/392846f946e14e8f98dc2d66a6635162

@SirYwell
Copy link
Member Author

I tried your PR and had a few errors athion.net/ISPaster/paste/view/392846f946e14e8f98dc2d66a6635162

That seems to be unrelated. Please test on the latest build and open a separate issue for it.

@Tsoccerguy3
Copy link

As I pointed out in a Discord Chat. Builds 1071 and 1072 have a data fixer issue error thar pops up in
Console on start up. https://discord.com/channels/268444645527126017/344128526435221505/1354025102878183506

@SirYwell
Copy link
Member Author

As I pointed out in a Discord Chat. Builds 1071 and 1072 have a data fixer issue error thar pops up in Console on start up. discord.com/channels/268444645527126017/344128526435221505/1354025102878183506

Yes, this is fixed by this PR. But that does not mean the other problem is in any way related.

@Tsoccerguy3
Copy link

I applied the the PR and it fixed the console errors in build 1072 but in game errors started

@SirYwell
Copy link
Member Author

The error you shared here is completely unrelated.

@dordsor21 dordsor21 requested a review from a team March 28, 2025 15:16
@SirYwell SirYwell merged commit 39dc549 into main Mar 30, 2025
9 checks passed
@SirYwell SirYwell deleted the fix/nbt-actor-check branch March 30, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix This PR fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants