Improve state applying pattern performance #3149
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Description
There are multiple things that can be improved about the state applying pattern:
BV3#getBlock(Extent)instead ofExtent#getBlock(BV3)computeIfAbsent. Not only has that method a very high complexity, but the capturing lambda causes an allocation every timeHere is a diff showcasing how this change affects the performance of the

applyBlockmethod when running//set ^[snowy=true]on a selection of 2048x320x2048:Submitter Checklist
@since TODO.