-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use a holder to allow "upgrading" LocalBV3Set to a full fat one #3051
Conversation
Do we need to expose Also the |
Yeah I can probably move it into the local directly as there's no reason to have a holder for a full fat bv3set. I also just copied the fact the local already had a clone method tbh, but yeah copy would also be consistent with everything else in FAWE |
4e4be5e
to
234667a
Compare
worldedit-core/src/main/java/com/fastasyncworldedit/core/math/LocalBlockVectorSet.java
Show resolved
Hide resolved
worldedit-core/src/main/java/com/fastasyncworldedit/core/math/BlockVectorSet.java
Outdated
Show resolved
Hide resolved
worldedit-core/src/main/java/com/fastasyncworldedit/core/util/collection/BlockVector3Set.java
Outdated
Show resolved
Hide resolved
worldedit-core/src/main/java/com/fastasyncworldedit/core/math/BlockVectorSet.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also noticed CachedMask
catches UnsupportedOperationException
, should that be adjusted too? I guess those try-catch blocks can just be removed this way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a/some issue(s) that were due to a local set being used assumptively. The only instances of the local sets being explicitly used should now only be when using chunk coords, or for the floating tree remover