Skip to content

Conversation

@SirYwell
Copy link
Member

@SirYwell SirYwell commented Nov 1, 2024

Overview

Fixes #2971

Description

With the coordinated undo, we now reuse MutableTileChange and MutableEntityChange across create and remove changes. This however requires us to also adjust the change in that regard. Unconditionally writing the currently expected value is most likely the simplest solution.

This is not a problem for other change types as we don't have the create/remove situation there.

### Submitter Checklist
- [x] Make sure you are opening from a topic branch (**/feature/fix/docs/ branch** (right side)) and not your main branch.
- [x] Ensure that the pull request title represents the desired changelog entry.
- [x] New public fields and methods are annotated with `@since TODO`.
- [x] I read and followed the [contribution guidelines](https://github.com/IntellectualSites/.github/blob/main/CONTRIBUTING.md).

@SirYwell SirYwell requested a review from a team as a code owner November 1, 2024 10:38
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Nov 1, 2024
@dordsor21 dordsor21 requested a review from a team November 1, 2024 11:04
@dordsor21 dordsor21 merged commit 9eafbf1 into main Nov 4, 2024
@dordsor21 dordsor21 deleted the fix/mutable-change-direction branch November 4, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix This PR fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clobbered block data cannot be undone (sometimes)

4 participants